Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://feat-global-agent-setup-viteplus-dev.voidzero-docs.workers.dev (commit 6ba33fb)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2487b8a2d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Before Running Commands | ||
|
|
||
| - Follow repository-local agent instructions when present. | ||
| - Run `vp --version` to confirm the global CLI is available. If it is missing, point the user to https://viteplus.dev/guide/global-cli instead of silently substituting npm or another tool. |
There was a problem hiding this comment.
When this skill runs in a project where vp --version resolves a project-local Vite+ binary, the check succeeds even though the global CLI needed by this skill is absent. The new setup instructions explicitly state that only vp toolchain --global proves a global installation (docs/public/agent-setup/prompt.md:9), so use that check here as well; otherwise subsequent global-only commands such as vpx can fail after the skill incorrectly proceeds.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
| Find the current agent's identifier in the definitive [Supported Agents](https://github.com/vercel-labs/skills#supported-agents) table. Install the skill only for that agent; replace `<agent-id>` with its identifier and do not use `*`. | ||
|
|
||
| ```bash | ||
| vp dlx skills add https://github.com/voidzero-dev/vite-plus/tree/main/skills/vite-plus --global --yes --agent <agent-id> |
There was a problem hiding this comment.
When these instructions are served from a PR or other non-production docs deployment, this URL still downloads from main. This commit introduces skills/vite-plus for the first time, so the current PR preview points to a path that does not yet exist on main and the advertised setup fails at skills add; future previews can likewise install a skill version that does not match the preview. Use a revision-aware source or host the skill with the preview, consistent with the prompt's same-release handling.
AGENTS.md reference: AGENTS.md:L31-L35
Useful? React with 👍 / 👎.
|
We need to test the prompt properly as it differs with the previous by a lot. |
2487b8a to
35e9a26
Compare
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35e9a26377
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### Existing project | ||
|
|
||
| Migrate this project to Vite+ while preserving its application, test, and library build behavior. |
There was a problem hiding this comment.
When the homepage prompt is used only to install the advertised global CLI and skill from inside an existing non-Vite+ repository, these instructions provide no setup-only exit: the only matching existing-project flow immediately tells the agent to migrate the repository. This can modify dependencies and configuration without the user ever requesting adoption, and directly conflicts with skills/vite-plus/SKILL.md:30, which prohibits unrequested migrations. Stop after global setup unless creation, migration, or upgrade was explicitly requested, or ask the user before entering one of these flows.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92cb423017
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - Default to `vp create`; do not use `npm create`, `npx create-*`, or another package-manager-specific scaffold command unless the user explicitly requests it or `vp create` cannot run the requested source. | ||
| - Run `vp create --list` or read https://viteplus.dev/guide/create when choosing a template. | ||
| - Keep the template as the first argument. For shorthand and remote templates, pass their target and options after `--`; for example, `vp create vite -- web-app --template react-ts`. Use `--directory` for Vite+ built-in, local, and bundled organization templates. |
There was a problem hiding this comment.
--
When an agent runs a template registered in create.templates, this guidance makes it use the top-level --directory, but packages/cli/src/create/bin.ts:492-495 rejects that option for everything except built-ins and bundled organization templates. Local generators instead receive their directory option as a template argument (for example, the existing fixture uses vp create my-generator ... -- --directory missing-name), so following the new skill or matching guide text causes these scaffolds to exit before the template runs.
AGENTS.md reference: AGENTS.md:L33-L35
Useful? React with 👍 / 👎.
| let skillSource = 'https://github.com/voidzero-dev/vite-plus/tree/main/skills/vite-plus'; | ||
| if (siteOrigin) { |
There was a problem hiding this comment.
The preview fix now pins revisions only inside if (siteOrigin), but production deployments deliberately leave siteOrigin empty and are built from the latest stable release commit (.github/workflows/release.yml:262-288). Consequently, the published prompt always installs from the moving main branch; after main changes the skill without another stable docs deployment, users of the stable site receive guidance that no longer matches its CLI or documentation. Use the available DOCS_GIT_SHA for production as well rather than the moving branch.
AGENTS.md reference: AGENTS.md:L33-L35
Useful? React with 👍 / 👎.
|
I reviewed the setup prompt by use case and tested it with fresh Codex sessions in disposable directories. The explicit/implicit loading scenarios follow the official Codex skills guidance. Fixes found through testing
Scenario results
No real global agent configuration was changed during these tests. Automated and deployed verification
The root |
92cb423 to
6ba33fb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ba33fb3fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Options | ||
|
|
||
| - `--directory <dir>` writes the generated project into a specific target directory | ||
| - `--directory <dir>` writes Vite+ built-in, local, and bundled organization templates into a specific target directory. For shorthand and remote templates, pass their target directory after `--` using that template's syntax. |
There was a problem hiding this comment.
--directory support
Although the skill text was corrected, this new guide sentence still tells users of a registered create.templates generator to pass the top-level --directory. For that scenario, packages/cli/src/create/bin.ts:492-496 rejects the option because local templates are not direct scaffold templates; the existing snapshot fixture instead forwards --directory after --. Document local templates alongside shorthand and remote templates so their generator receives the directory argument.
AGENTS.md reference: AGENTS.md:L33-L35
Useful? React with 👍 / 👎.
This branch has not been deployed
2 participants
Adds a hosted agent setup prompt and global Vite+ skill, with one-click prompt copying. Closes #2781.