Repository navigation
fix(dlx): run npx for npm 6 - #3479
Open
jong-kyung wants to merge 1 commit into
Open
jong-kyung wants to merge 1 commit into
jong-kyung wants to merge 1 commit into
Conversation
npm exec landed in npm 7.0.0, so vp dlx printed npm's usage text instead of running the package under npm 6. npm 6 now runs its standalone npx, without --yes because that npx takes the following word as the value of the unknown option.
Collaborator
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
marked this pull request as ready for review
November 17, 2026 10:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp dlxbuiltnpm exec --yesfor every npm version, butnpm execfirst shipped in npm 7.0.0. Under npm 6,vp dlxprinted npm's usage text and exited with code 1 instead of running the package.npm 6 now runs its standalone
npx. The command leaves out--yes, because thatnpxtakes the word after an unknown option as its value and would swallow the package name. It also leaves out--, because thatnpxalready passes everything after the command through untouched, and it maps--silentto--quiet.vp createwill need this once #3478 routes remote templates throughvp dlx.