Skip to content

fix(dlx): run npx for npm 6 - #3479

Open
jong-kyung wants to merge 1 commit into
voidzero-dev:mainfrom
jong-kyung:fix/dlx-npm6-npx
Open

jong-kyung wants to merge 1 commit into
voidzero-dev:mainfrom
jong-kyung:fix/dlx-npm6-npx

Conversation

@jong-kyung

@jong-kyung jong-kyung commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

vp dlx built npm exec --yes for every npm version, but npm exec first shipped in npm 7.0.0. Under npm 6, vp dlx printed npm's usage text and exited with code 1 instead of running the package.

npm 6 now runs its standalone npx. The command leaves out --yes, because that npx takes the word after an unknown option as its value and would swallow the package name. It also leaves out --, because that npx already passes everything after the command through untouched, and it maps --silent to --quiet.

vp create will need this once #3478 routes remote templates through vp dlx.

npm exec landed in npm 7.0.0, so vp dlx printed npm's usage text instead of running the package under npm 6. npm 6 now runs its standalone npx, without --yes because that npx takes the following word as the value of the unknown option.
@jong-kyung jong-kyung self-assigned this Nov 17, 2026
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T10:49:01.409928Z 1dda98c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jong-kyung jong-kyung added test: e2e Auto run e2e tests test: create-e2e Run `vp create` e2e tests labels Nov 17, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 1dda98cc70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jong-kyung
jong-kyung marked this pull request as ready for review November 17, 2026 10:44
@jong-kyung
jong-kyung requested a review from fengmk2 November 17, 2026 10:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant