Repository navigation
fix(global): keep npm aliases through list, outdated, and update - #3480
Draft
liangmiQwQ wants to merge 1 commit into
Draft
liangmiQwQ wants to merge 1 commit into
liangmiQwQ wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2256
The current global commands forget that a package was installed as an npm alias. After
vp install -g typescript@npm:cowsay,vp list -gshows a faketypescript@1.6.0.vp outdated -gcompares cowsay's version with TypeScript's. Andvp up -g typescriptreinstalls the realtypescriptin place of cowsay.This PR records the alias in the existing
versionSpecmetadata (npm:cowsayornpm:cowsay@^1). Updates then reinstall through the alias:vp up -g typescriptkeeps the alias and its range.vp up -g typescript --latestdrops the range but keeps the alias (npm:cowsay).vp up -g typescript@6installs the real package, same asnpm install.npm viewrejects alias specs, so registry lookups query the aliased package (cowsay@^1) instead. Following the expected behavior in npm/cli#9706,vp outdated -gshows alias versions ascowsay@1.6.0andvp list -gshowstypescript@npm:cowsay@1.6.0.Aliases installed before this change have no recorded spec, so they need one reinstall to pick this up.
🤖 Generated with Claude Code