Skip to content

feat: android support#326

Open
Ludea wants to merge 10 commits intovoidzero-dev:mainfrom
Ludea:android
Open

feat: android support#326
Ludea wants to merge 10 commits intovoidzero-dev:mainfrom
Ludea:android

Conversation

@Ludea
Copy link
Copy Markdown

@Ludea Ludea commented Apr 10, 2026

Add android support

@Ludea Ludea changed the title android support feat: android support Apr 10, 2026
[target.'cfg(all(unix, not(target_env = "musl")))'.dependencies]
fspy_preload_unix = { workspace = true }
#[target.'cfg(all(unix, any(not(target_env = "musl"), not(target_os = "android"))))'.dependencies]
#fspy_preload_unix = { workspace = true }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fspy needs fspy_preload_unix on macOS and glibc Linux

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ipc channel is only used by LD_PRELOAD. Since we won't use that in android (same as musl), we don't need to fix it for android. You can completely skip compiling this module.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I've gated them in #327 and #328. You can now try adding not(android) to the cfg and removing the code changes to the ipc module.

Copy link
Copy Markdown
Author

@Ludea Ludea Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I excluded ipc module, like musl host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants