Repository navigation
Newlines in arguments passed to node -e ... #1791
Description
We ran into an issue when calling node -e ... with a script that contains new lines. pulumi/pulumi#16649
Repro:
main.go:
package main
import (
"fmt"
"os/exec"
)
func main() {
argWithNewLines := `if (true) {
console.log("it's true!");
}`
cmd := exec.Command("node", "-e", argWithNewLines)
out, err := cmd.Output()
if err != nil {
fmt.Printf("Error: %s", err)
}
fmt.Println(string(out))
}Run with:
go run main.go
When I have the Volta shim node.exe in the path, I get an error:
PS C:\Users\pulumiadmin> go run main.go
Error: exit status 1
With the actual node.exe on path, it works:
PS C:\Users\pulumiadmin> go run main.go
it's true!
Activity
chriskrycho commentedon Jul 12, 2024
Ah, thanks for the report! That is indeed quirky, and we should make sure we pass that through cleanly!
karthest commentedon Aug 10, 2024
That's weired , it's totally OK on wsl2 ubuntu with volta v1.1.1 and node v20.12.2. Maybe the issue is related to a specific environment
julienp commentedon Aug 10, 2024
I am not much of a Windows user, from what I remember, I was able to reproduce this on a Windows (11 I think?) VM in Azure, not using WSL, no special config on the VM. We had at least 2 Pulumi users report an issue, where we narrowed down the root cause to this issue.
I don't know how the Volta shims work, but I guess when running under WSL it's doing an
execsyscall, but on plain Windows it will have to do something more intricate I believe?charlespierce commentedon Aug 16, 2024
Thanks for the reports, and the environment investigation! I suspect this might be related to the fact that we use
cmd /Cto execute the shimmed packages—I wonder if there's some strange argument handling there that is making it not parse correctly. I do a lot of my individual development on Windows, so should be able to investigate this weekend.charlespierce commentedon Oct 3, 2024
Didn't get to investigating that weekend 😅 However just now I did confirm, and from some digging online, I think this might be a hard limitation of
cmd.exe, which we use internally to handle resolving executables on Windows.However, as mentioned in my most recent comment on #1761, that PR may provide a path forward to removing that use of
cmd.exeentirely, which would (hopefully) resolve this in passing. I'm hoping to get an investigatory PR up that does that sometime today, though my flight is landing so I may run out of time!jabdinghoff commentedon Apr 28, 2026
After some crazy debugging I also found out that this results in the vaadin gradle plugin breaking
https://github.com/vaadin/flow/blob/845056362fb468fc34de79d6da6acd2e50100776/flow-build-tools/src/main/java/com/vaadin/flow/server/frontend/FrontendTools.java#L528-L540
This basically runs:
And the
\nhere drops theconsole.logso it returns nothing and this results in this cryptic error:The empty string gets replaced with the cwd so it shows the gradle daemon directory.
Mostly writing this out here so other people who ran into this can find this googling.
Fix: keep the node runtime probe clear of cmd.exe metacharacters
Fix: keep the node runtime probe clear of cmd.exe metacharacters
Fix: keep the node runtime probe clear of cmd.exe metacharacters (#458)