Skip to content

Experiment: optimize compressor selection for scan time #8780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connortsui20 wants to merge 1 commit into from
+792 −31
Closed

Experiment: optimize compressor selection for scan time #8780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bench-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
env:
RUSTFLAGS: "-C target-cpu=native"
run: |
cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings
cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }}

- name: Setup Polar Signals
if: github.event.pull_request.head.repo.fork == false
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/sql-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,10 +576,12 @@ jobs:
RUSTFLAGS: "-C target-cpu=native"
run: |
packages=(--bin data-gen --bin datafusion-bench --bin duckdb-bench)
features=()
if [ "${{ inputs.mode }}" != "pr" ]; then
packages+=(--bin lance-bench)
features+=(--features unstable_encodings)
fi
cargo build "${packages[@]}" --profile release_debug --features unstable_encodings
cargo build "${packages[@]}" "${features[@]}" --profile release_debug
Comment on lines 580 to +584

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep benchmark feature sets aligned

When inputs.mode == 'pr', features stays empty here, but this workflow's compare step still downloads data.json.gz from the develop benchmark results, and develop mode takes this same branch the other way and adds --features unstable_encodings. That means PR SQL benchmark comments now compare stable-encoding PR binaries against unstable-encoding develop baselines, so unrelated PRs can be reported as faster/slower because of the feature-policy difference rather than their changes. Please either produce a matching stable baseline or keep the PR and develop feature sets aligned for comparisons.

Useful? React with 👍 / 👎.


- name: Generate data
shell: bash
Expand Down
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions vortex-btrblocks/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ insta = { workspace = true }
rstest = { workspace = true }
test-with = { workspace = true }
vortex-array = { workspace = true, features = ["_test-harness"] }
vortex-mask = { workspace = true }
vortex-session = { workspace = true }

[features]
Expand All @@ -64,3 +65,8 @@ test = false
name = "compress_listview"
harness = false
test = false

[[bench]]
name = "stable_tradeoff"
harness = false
test = false
Loading
Loading