fix(spark): reject MapType instead of emitting a childless Arrow List#8811
Open
jackylee-ch wants to merge 1 commit into
Open
fix(spark): reject MapType instead of emitting a childless Arrow List#8811jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
SparkToArrowSchema mapped MapType to a childless ArrowType.List, which is an invalid Arrow list (List requires exactly one child). Drop the branch so MapType falls through to the fail-fast UnsupportedOperationException, and add a test. Signed-off-by: jackylee <qcsd2011@gmail.com>
Merging this PR will improve performance by 11.17%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SparkToArrowSchemamappedMapTypeto a childlessArrowType.List, which is an invalid Arrow list (a List must have exactly one child). Drop the branch soMapTypefalls through to the existing fail-fastUnsupportedOperationException, and add a test.