Skip non-leaf conjunct pairs in find_between - #9764
Conversation
Merging this PR will improve performance by 21.06%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | arrow_checked_add_u32_neon[16384] |
20.5 µs | 12.8 µs | +60.48% |
| ⚡ | Simulation | decompress[u64, (4000, 1024)] |
85.5 µs | 71.3 µs | +19.83% |
| ⚡ | Simulation | optimize_lookup_predicate[ids=16, shape=balanced_or] |
82.5 µs | 71.4 µs | +15.53% |
| ⚡ | WallTime | filtered_sink_i64_neon[NineNullsInTen] |
28.5 µs | 25 µs | +13.75% |
| ⚡ | Simulation | allocate_drop_bytes[0] |
520.2 ns | 466 ns | +11.62% |
| ⚡ | WallTime | filtered_owned_i64_neon[NineNullsInTen] |
28 µs | 25.1 µs | +11.61% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/find-between-skip-nonbound (bf2586c) with develop (a997c3f)
Footnotes
-
206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
576b592 to
50f898a
Compare
Signed-off-by: Robert Kruszewski <github@robertk.io>
50f898a to
bf2586c
Compare
find_between only needs to find binary comparison pairs, we don't need to
traverse the whole expression tree