Skip to content

Skip non-leaf conjunct pairs in find_between - #9764

Open
robert3005 wants to merge 1 commit into
developfrom
perf/find-between-skip-nonbound
Open

Skip non-leaf conjunct pairs in find_between#9764
robert3005 wants to merge 1 commit into
developfrom
perf/find-between-skip-nonbound

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

find_between only needs to find binary comparison pairs, we don't need to
traverse the whole expression tree

@codspeed-hq

codspeed-hq Bot commented Sep 4, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 21.06%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
✅ 2193 untouched benchmarks
⏩ 206 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 20.5 µs 12.8 µs +60.48%
Simulation decompress[u64, (4000, 1024)] 85.5 µs 71.3 µs +19.83%
Simulation optimize_lookup_predicate[ids=16, shape=balanced_or] 82.5 µs 71.4 µs +15.53%
WallTime filtered_sink_i64_neon[NineNullsInTen] 28.5 µs 25 µs +13.75%
Simulation allocate_drop_bytes[0] 520.2 ns 466 ns +11.62%
WallTime filtered_owned_i64_neon[NineNullsInTen] 28 µs 25.1 µs +11.61%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing perf/find-between-skip-nonbound (bf2586c) with develop (a997c3f)

Open in CodSpeed

Footnotes

  1. 206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005
robert3005 force-pushed the perf/find-between-skip-nonbound branch 2 times, most recently from 576b592 to 50f898a Compare September 4, 2026 16:06
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 force-pushed the perf/find-between-skip-nonbound branch from 50f898a to bf2586c Compare September 5, 2026 12:47
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant