Repository navigation
Conversation
Update spec for params.pp to Hiera conversion
kenyon
requested changes
Oct 25, 2026
Member
There was a problem hiding this comment.
EL7 is unsupported, you can delete this.
Member
There was a problem hiding this comment.
Data in common should instead be class parameter defaults in init.pp, and then you can replace the lookup() calls with the variable, e.g., $python::pip_lookup_path.
Comment on lines
+66
to
+69
| unless $facts['os']['family'] in ['AIX', 'Debian', 'FreeBSD', 'Gentoo', 'RedHat', 'Suse', 'Archlinux'] { | ||
| fail("Module is not compatible with ${facts['os']['name']}") | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
There is no need for this check. It just makes the module difficult to use on platforms that aren't officially supported.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR moves the OS-dependent defaults from
python::paramsinto data inmodules and removes the private
python::paramsclass and the obsoleteparams.pp(see #712 )This Pull Request (PR) fixes the following issues
Fixes #712