Websocket types - #601
Open
C0D3-M4513R wants to merge 47 commits into
Open
Websocket types#601C0D3-M4513R wants to merge 47 commits into
C0D3-M4513R wants to merge 47 commits into
Conversation
C0D3-M4513R
force-pushed
the
feature/websocket
branch
2 times, most recently
from
September 16, 2026 17:52
742b44e to
91b5283
Compare
C0D3-M4513R
force-pushed
the
feature/websocket
branch
3 times, most recently
from
September 16, 2026 18:01
5b4cd87 to
87e2c20
Compare
commit: |
C0D3-M4513R
force-pushed
the
feature/websocket
branch
from
September 16, 2026 18:15
80b23d2 to
051f92a
Compare
C0D3-M4513R
requested review from
ariesclark
and
a lite review from Copilot
September 16, 2026 18:58
C0D3-M4513R
marked this pull request as ready for review
September 16, 2026 18:59
Contributor
Author
|
This approach does not work for actually deserializing the double-json encoded json, sadly. Also the discriminator mappings do not work (at least in rust). If possible I'd like someone more skilled at Openapi spec to look at this. |
C0D3-M4513R
force-pushed
the
feature/websocket
branch
2 times, most recently
from
September 16, 2026 23:05
8a8e988 to
31dae62
Compare
Contributor
Author
|
So the descriminator mappings work now. Therefore, due to how at least Rust enums work, I had to create one type with the suffix "Encoded" for each Websocket double-encoded type. |
C0D3-M4513R
marked this pull request as draft
September 17, 2026 00:46
C0D3-M4513R
force-pushed
the
feature/websocket
branch
from
September 22, 2026 10:54
5b5f3d6 to
b48648a
Compare
Merged
C0D3-M4513R
force-pushed
the
feature/websocket
branch
3 times, most recently
from
September 22, 2026 19:48
f517c46 to
f47aa14
Compare
C0D3-M4513R
added a commit
to vrchatapi/vrchatapi-rust
that referenced
this pull request
Sep 23, 2026
#47) * Template Changes for vrchatapi/specification#601 * Fix examples * fmt * More robust template * Implement/Use C0D3-M4513R/specification@db4c9c3 * Fix examples * Use openapi-3.1 spec * Change vendor-specific namings
C0D3-M4513R
force-pushed
the
feature/websocket
branch
from
September 23, 2026 18:54
77ab1e3 to
05b6fbe
Compare
C0D3-M4513R
force-pushed
the
feature/websocket
branch
from
September 23, 2026 19:03
e458b6e to
78fbde9
Compare
Created using `for i in WebsocketNotification.yaml WebsocketResponseNotification.yaml WebsocketNotificationV2Update.yaml WebsocketNotificationV2Delete.yaml WebsocketFriendAdd.yaml WebsocketFriendDelete.yaml WebsocketFriendOnline.yaml WebsocketFriendActive.yaml WebsocketFriendOffline.yaml WebsocketFriendUpdate.yaml WebsocketFriendLocation.yaml WebsocketUserUpdate.yaml WebsocketUserLocation.yaml WebsocketUserBadgeAssigned.yaml WebsocketUserBadgeUnassigned.yaml WebsocketContentRefresh.yaml WebsocketInstanceQueueJoined.yaml WebsocketInstanceQueueReady.yaml WebsocketGroupJoined.yaml WebsocketGroupLeft.yaml WebsocketGroupMemberUpdated.yaml WebsocketGroupRoleUpdated.yaml; do echo -e "title: ${i%.*}Encoded\ntype: object\nproperties:\n content:\n type: string\n contentMediaType: application/json\n contentSchema:\n \$ref: ./${i}\nrequired:\n - content" > ${i%.*}Encoded.yaml; done`
generated using: `for i in NotificationDetailBoop NotificationDetailInvite NotificationDetailInviteResponse NotificationDetailRequestInvite NotificationDetailRequestInviteResponse NotificationDetailVoteToKick; do echo -e "title: Websocket$i\ntype: object\nproperties:\n details:\n \$ref: ./$i.yaml\nrequired:\n - details" > Websocket$i.yaml; done`
C0D3-M4513R
force-pushed
the
feature/websocket
branch
from
September 23, 2026 21:59
862d336 to
33472b6
Compare
Some files generated using: `for i in NotificationDetailBoop NotificationDetailInvite NotificationDetailInviteResponse NotificationDetailRequestInvite NotificationDetailRequestInviteResponse NotificationDetailMessage NotificationDetailFriendRequest NotificationDetailVoteToKick; do echo -e "title: ${i}Encoded\ntype: object\nproperties:\n details:\n type: string\n contentMediaType: application/json\n contentSchema:\n \$ref: ./$i.yaml\n x-vrchat-double-encoding-type: $i\nrequired:\n - details\nx-vrchat-double-encoding: true" > ${i}Encoded.yaml; done`
C0D3-M4513R
marked this pull request as ready for review
September 23, 2026 22:36
Contributor
Author
|
I've fixed the the Rust CI-Error with a new commit in the rust repo. |
# Conflicts: # openapi/components/schemas/Notification.yaml
# Conflicts: # openapi/components/schemas/_index.yaml #
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bunch of types used for receiving Websockets