docs: report component-attribute override bug in DiagnosticsMetrics - #712
Open
juliobguedes wants to merge 1 commit into
Open
juliobguedes wants to merge 1 commit into
juliobguedes wants to merge 1 commit into
Conversation
Found while validating the 6.x diagnostics-metrics backport against production ClickHouse data: DiagnosticsMetrics.mergeAttributes gives base attributes precedence over conflicting custom attributes, and timings.ts sets component: 'http-handler' as a base attribute for the whole request scope. Every outbound HTTP client call made while handling that request (metrics.ts's own component: 'http-client') gets silently relabeled as 'http-handler' in the shared io_app_operation_duration_milliseconds histogram. Confirmed via production data: for vtex.search-resolver@1.114.0 in cluster iostore-f3t over 1 hour, http_handler_requests_total shows 72,587 while io_app_operation_duration_milliseconds filtered to component='http-handler' shows 16,104,556 (~222x). Reproducible on master today, independent of the 6.x backport -- not a regression, a pre-existing latent bug in code both branches share verbatim. This document is input for a future spec/change fixing it on both branches. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (31.90% Estimated after merge)
DK Review — Audit SummaryVerdict: ⏳ INCOMPLETE
Only BLOCK and RESTRICT findings anchored to a changed line are commented inline on the diff. The 2 findings below open no review thread. Scenarios evaluated: general-review 📋 Findings (2)SUGGEST
DK Review v1.0.0 | To dismiss a finding: reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6.xdiagnostics-metrics backport (docs(openspec): propose observability diagnostics for node-vtex-api@6.x #710/feat(telemetry): backport diagnostics metrics observability to 6.x #711) against production ClickHouse data:DiagnosticsMetrics's base-attribute precedence rule silently relabels every outbound HTTP client call'scomponentattribute as'http-handler'when it happens inside a request'stimings.ts-scopedrunWithBaseAttributescall.vtex.search-resolver@1.114.0, clusteriostore-f3t):http_handler_requests_total= 72,587 vs.io_app_operation_duration_millisecondsfiltered tocomponent='http-handler'= 16,104,556 — a ~222x mismatch.mastertoday, independent of the6.xwork — this is a pre-existing latent bug in code both branches share verbatim, not a regression.masterand6.x.Test plan
🤖 Generated with Claude Code