Repository navigation
Step relief preview handles by physical layers - #110
Conversation
- Prevent Float32 relief bounds from adding phantom top-layer steps - Cover exact ten-layer moves, constrained limits, and both-handle reset - Update the unreleased changelog entry
Automated review and fixesPushed Findings
Verification: E2E Fixed by GPT 6.1 Sol |
# Conflicts: # CHANGELOG.md
Relief preview handles use a 0.01 mm Radix slider step. At the default 0.12 mm layer height, an arrow-key change snaps back to the same printed layer, leaving keyboard users unable to step through the model.
Handle relief arrow keys in physical layer-boundary indices, including the distinct first layer. Shift+arrow and Page Up/Down move ten layers; Home/End reach the constrained limits. Keep proportional pointer positions, ordered cutoffs, rebuild reset, Flat Paint's existing index behavior, and exported geometry unchanged. Document the keys in all twelve guide languages.
Fixes #106.
Validation:
npm run lint: passed.npm run build: passed, including TypeScript and i18n checks.npm test: 860 passed, 1 skipped, 0 failed.npm run test:docs: 3 passed after localized guide updates.PLAYWRIGHT_BROWSERS_PATH=/Users/vycdev/Desktop/kromacut-e2e/.playwright npx playwright test tests/e2e/relief-layer-preview.spec.ts tests/e2e/flat-paint-preview.spec.ts: 4 passed in Chromium.PLAYWRIGHT_BROWSERS_PATH=/Users/vycdev/Desktop/kromacut-e2e/.playwright npx playwright test --config ../perf/layer-webkit.config.ts: 1 passed against this branch's dev server.git diff --check: passed.The new regression covers both handles, first-layer boundaries, range constraints, larger steps, Home/End, and rebuild reset. Existing Flat Paint tests cover full-slab export and failure recovery. The native release defect was exercised twice; the patched desktop binary was not rebuilt, as required by the QA brief.
Repository target note: this feature branch was cut from latest main as requested by the QA brief. The repository only permits develop→main PRs, so this PR targets develop (currently the same source tree as main). Earlier
Require develop into mainfailures are historical branch-policy checks from the initial target, not code/test failures; GitHub may still show them on this head.