Skip to content

πŸ›πŸ§‘β€πŸ’» - bugfix setup generated runner groups fail source workflow validationΒ #570

Closed

Description

@efraespada

Is there an existing issue for this?

Which actions are affected?

Pull Request, Commits

Which platforms are affected?

Linux, macOS, Windows

Description

The #556 setup generates a valid source-repository job route using an existing runner group and literal labels, but the repository workflow contract validator rejects that same route. This blocks the source parity installer PR copilot #568 even though the generated profile successfully ran in GitHub on platform.

Expected: the validator accepts the bounded literal object form supported by the setup, while continuing to enforce job-role routing, label requirements and GitHub-hosted credential verification. It must still reject unsafe expressions or malformed runner objects. Existing source native workflow routes should retain their reviewed behavior.

Actual: runnerLabels(value) in scripts/validate-workflow-contract.cjs maps arrays and otherwise applies String(value). A {group, labels} object becomes [object Object], so an otherwise correct self-hosted route fails the label contract.

Reproducing the issue

  1. Run the CLI from reviewed develop merge f09d3222ffdf9ad88e869e754c6f90af522ca8eb after [#556] ✨ - feat select reusable runner profiles in setup and reconcile source workflow parity #563, using organization configuration reuse and two targets: vypdev/copilot and vypdev/platform.
  2. Choose an existing self-hosted runner, group vypdev, labels self-hosted,codex,Linux, with ordinary validation hosted. Review and apply the batch.
  3. Source installer chore: configure CopilotΒ #568 is at exact prepared commit 74bdb19399bbd84266882930588ca4e6520f7209. Its new .github/workflows/agent-cli-provisioning.yml contains:
runs-on:
  group: vypdev
  labels: [self-hosted, codex, Linux]
  1. The Ubuntu setup smoke job 117780207027 passed 631 suites / 9,459 tests and coverage budgets, then failed validate:workflows with:
.github/workflows/agent-cli-provisioning.yml job verify-agent-clis must use runs-on self-hosted, codex.
  1. To separate this bug from an older published validator, archive current develop f09d3222, overlay the exact 20 changed files of chore: configure CopilotΒ #568, and run node scripts/validate-workflow-contract.cjs. The current develop validator also exits 1 with the same provisioning error. No repository branch or CI check was modified for this reproduction.
  2. Contrast with the exact generated platform installation commit 0e962ee99417e1b5e4b93bcc21e4b8850834244c: provisioning run 39163029973 passed on runner ubuntu-runner-2, runner group ID 4 / vypdev, with the selected labels.

copilot Version

CLI and current-validator reproduction: develop f09d3222ffdf9ad88e869e754c6f90af522ca8eb (#563). Source installation base: master v3.5.6.

Relevant Log Output

The published master validator separately rejects the newly installed hosted credential-health route; current develop already contains that role-specific exception. Updating the source version alone does not resolve the grouped provisioning route above.

Additional context and comments

The batch created copilot #568 and vypdev/platform#180 with matching commit, parent, branch and manifest receipts. Organization/repository Variables and Secret metadata stayed unchanged. Installation PRs remain unmerged. The temporary setup PAT copy was removed and the operator was notified that it can be revoked. Dependency vulnerabilities remain outside this issue.

Activity

  1. added
    bugSomething isn't working
    bugfixSomething isn't working
    priority: highCritical issue, needs immediate attention.
    on Oct 18, 2026
  2. added theissue type on Oct 18, 2026
  3. moved this to Todo in vypdevon Oct 18, 2026
  4. changed the title [-]bugfix: setup-generated runner groups fail source workflow validation[/-] [+]πŸ› - bugfix setup generated runner groups fail source workflow validation[/+] on Oct 18, 2026
  5. vypbot commented on Oct 18, 2026

    @vypbot
    Contributor

    Hi! I’m @vypbot, the Copilot assistant for this repository.

    I can answer questions, explain the codebase, propose implementation and test plans, review issues and pull requests for potential bugs or security problems, and help authorized maintainers apply changes.

    Try /copilot help to see the available commands, or mention @vypbot with your question.

  6. moved this from Todo to In Progress in vypdevon Oct 18, 2026
  7. added
    branchedIndicates that a branch has been created for this issue.
    on Oct 18, 2026
  8. changed the title [-]πŸ› - bugfix setup generated runner groups fail source workflow validation[/-] [+]πŸ›πŸ§‘β€πŸ’» - bugfix setup generated runner groups fail source workflow validation[/+] on Oct 18, 2026
  9. 2 remaining items

  10. vypbot commented on Oct 18, 2026

    @vypbot
    Contributor

    Issue closed β€” historical progress

    Current status: closed as completed.

    The last estimate is retained below as history. Closure does not certify a new percentage, tests, or branch alignment.

    Action required: none for this closed issue. If work continues, reopen the issue; a fresh assessment can update this same card.

    Last assessment before closure (historical)

    Progress: 90% β€” in progress

    > Current status: The validator now accepts bounded literal runner objects, preserves role and credential routing checks, adds focused positive and negative coverage, and documents the contract. The supplied comparison does not show that the validator or tests were run successfully; generated metadata is not evidence of verification.

    Next: Run the workflow contract validator and focused tests to verify the changes.

  11. added a commit that references this issue on Oct 18, 2026
  12. vypbot commented on Oct 18, 2026

    @vypbot
    Contributor

    Issue closed: synchronization recommendation retired

    No branch synchronization is required for this closed issue.

    The previous recommendation is historical. Issue closure does not certify that the branches are synchronized.

  13. vypbot commented on Oct 18, 2026

    @vypbot
    Contributor

    Issue closed: synchronization recommendation retired

    No branch synchronization is required for this closed issue.

    The previous recommendation is historical. Issue closure does not certify that the branches are synchronized.

  14. moved this from In Progress to Done in vypdevon Oct 18, 2026
  15. added
    100%Progress: 100%
    and removed
    in-progressStart work on an admitted issue.
    state:workingWork can proceed on the verified branch or without a branch.
    on Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

100%Progress: 100%branchedIndicates that a branch has been created for this issue.bugSomething isn't workingbugfixSomething isn't workingpriority: highCritical issue, needs immediate attention.size: SSmall-sized task or issue with minimal effort required.

Type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions