Repository navigation
[#538] ✨ - feat reuse organization configuration and set up selected repositories in one guided session - #546
Conversation
…-reuse-and-batch-setup.md
…-repositories-in-one-guided-session: reuse organization configuration and plan selected repository installs
…-repositories-in-one-guided-session: verify target branches and retain inherited PAT bindings
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on9f7f937. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit e6622da was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Secret revision changes are not detected before Apply —
src/application/usecases/actions/setup_resource_provisioning.ts:187 - low: Blank input accepts the preselected repository —
src/cli/setup_batch_adapter.ts:89
Bugbot: review complete
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #546 +/- ##
===========================================
+ Coverage 90.94% 93.85% +2.91%
===========================================
Files 135 926 +791
Lines 6251 29571 +23320
Branches 1338 8608 +7270
===========================================
+ Hits 5685 27754 +22069
- Misses 172 715 +543
- Partials 394 1102 +708
🚀 New features to boost your workflow:
|
…-repositories-in-one-guided-session: revalidate retained secret revisions and require explicit target confirmation
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on9f7f937. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit c6405f7 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Customize mode still requires existing shared credentials —
src/application/usecases/setup/configure_setup_batch_target_use_case.ts:36 - medium: Repository visibility drift bypasses reuse revalidation —
src/application/usecases/actions/setup_resource_provisioning.ts:185
…-repositories-in-one-guided-session: revalidate visibility and clarify batch credential reuse
…-repositories-in-one-guided-session: retain source setup contracts and verify interrupted operation recovery
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on9f7f937. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 3 potential problems when commit d16e644 was analyzed. This snapshot is historical; use the status block above for current state. 3 findings are linked to changed code.
Findings
- medium: Revalidate credential-health workflow state before Apply —
src/application/usecases/actions/setup_resource_provisioning.ts:203 - low: Rate-limited requests are never retried —
src/infrastructure/setup_batch_github_read_adapter.ts:37 - low: Partial source guidance inventory can rewrite existing artifacts —
src/infrastructure/setup_batch_workspace_adapter.ts:30
…-repositories-in-one-guided-session: use canonical guidance paths in setup workspace rendering
…-repositories-in-one-guided-session: revalidate setup facts and bound rate-limit recovery
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on9f7f937. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit 08584ae was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Imports target-specific project columns as answered organization settings —
src/application/policies/setup_organization_import_policy.ts:79 - medium: Partitioned progress analysis can fail on valid large file lists —
src/application/usecases/actions/summarize_progress_diff_workflow.ts:30
…-repositories-in-one-guided-session: retain target project choices and support complete progress aggregates
…-repositories-in-one-guided-session: budget complete progress facts within runtime prompt limits
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on9f7f937. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 3 potential problems when commit 5631e54 was analyzed. This snapshot is historical; use the status block above for current state. 3 findings are linked to changed code.
Findings
- medium: Organization reuse skips the final permission audit in terminal setup —
src/cli/commands/setup_execution.ts:306 - low: Incomplete Secret revisions can produce a ready plan —
src/application/usecases/setup/prepare_setup_batch_use_case.ts:54 - low: Schema and parser disagree on Unicode fact length —
specs/semantic-github-publication-and-notification.md:1772
…-repositories-in-one-guided-session: audit reused setup and retain validated resume outcomes
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on9f7f937. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit b279591 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Credential reuse ignores existing repository Secret overrides —
src/application/usecases/setup/configure_setup_batch_target_use_case.ts:46 - low: Local schema validation still counts UTF-16 code units —
specs/semantic-github-publication-and-notification.md:1771
…-repositories-in-one-guided-session: align shared schema Unicode bounds and prove Secret precedence
…-repositories-in-one-guided-session: cover setup failure paths and enforce batch module budgets
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on9f7f937. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 7165bbb was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Reuse writes repository overrides for inherited agent settings —
src/application/policies/setup_organization_variable_reuse_policy.ts:53
…-repositories-in-one-guided-session: retain generic agent variable inheritance during setup reuse
…-repositories-in-one-guided-session: complete setup diff coverage and verify bounded control flow
Extending Copilot to another organization repository repeats configuration and asks for existing credentials again. This adds compatible organization reuse and a reviewed setup journey for 1–25 explicitly selected repositories, shared by CLI and web.
Validation at
9f7f93777c6591c452e61713f83a9b09e17c2e8b: 663 suites / 10,268 tests passed, with 35 existing skips. The coverage follow-up adds 142 adverse-path tests, 13 generic-inheritance regressions and 35 final changed-path cases. Uploaded Codecov for this exact commit confirms 100% of modified coverable lines covered, agreeing with zero incomplete changed lines locally. The original report was 89.81861% with 174 incomplete lines; project coverage is now 93.85%. Eleven additional setup orchestration/provider modules enforce at least 95% statements/lines and 90% branches/functions. Existing pure-policy 100% gates and Codecov settings are unchanged. Maximum-inventory tests prove 1,000-resource ceilings, at most 34 Variable pages/ten Secret pages per snapshot, three read attempts and one write attempt. Redundant unreachable control flow and an unused final-audit confirmation capability are removed; no validation or limit is weakened. Build/package, TypeScript, lint, workflow, documentation and specification checks pass. The acceptance ledger retains its 14 explicitly open existing items.Real multi-repository setup used the packaged CLI and the organization PAT against vypdev/copilot and vypdev/platform. Operation
ad56b08c-ff59-46c8-b7aa-7f16a8ade406created reviewed installation PRs with 29/19 files, zero Variable writes and zero grants, exact prepared refs/parents and matching receipts. A controlled partial/retry retained the same commits and completed effects without duplicate PRs or ref overwrites. Platform #175 remains open for human review; its setup verification passes. Superseded source previews were closed unmerged after their native checks exposed compatibility defects that this PR corrects.Final source installation acceptance is copilot #562, operation
a2f8960d-ae01-4760-a0d5-ab6890299531, prepared commitfbaf4bbdcf5331067f2759665b2e50550e0a5a31: 16 files, zero Variable writes/grants, exact commit/parent/ref and matching receipt. Its CI, native review, Branch Sync, RepoWise and Ubuntu/macOS/Windows package-session checks pass. Direct GitHub inspection confirms retained native workflows/runners and canonical source guidance; the receipt is the sole manifest change. Optional provisioning/credential-health workflows match the currently installed source capabilities and remain disabled; their runner/profile parity work is tracked in #556. Actual completed-operation resume from the exact9f7f9377packaged CLI exits 0, returns the same #562 and unchanged prepared commit/ref, and repeats no permission-write probe or installation effect. Independent before/after snapshots show all six resource namespaces unchanged; the durable receipt is byte-identical. A separate read-only reconstruction also reproduces its exact reviewed plan digest and base without allocating a new operation.Independent pre/post hashes prove all six resource namespaces unchanged in the final installation: 73 organization Variables, six organization Secret metadata records, 12 copilot Variables, three copilot Secret metadata records, three platform Variables and no platform Secrets. The initial controlled run added only platform's missing
AGENT_ALLOWED_MODELS; all earlier resources were retained. A separate disposable live Variable test returned 201 then 409, preserved the original value, and confirmed deletion. Permission-probe cleanup was verified; owned residual probe workflow runs were canceled separately.Native multipart progress at the final head completed all four source parts, final assessment and current publication with zero Action errors. Native review completed all 18 analysis partitions: 22 findings fixed, zero open, with complete admitted source coverage and no omissions or dismissals. All current-head CI checks pass, including CI Check, RepoWise and Ubuntu/macOS/Windows package/session validation. A captured 149-file GitHub comparison replay preserves every source patch, and the long-path/worst-escaping 299-file regression fits the actual runtime ceiling without truncation.
Platform's released Action still fails its PR-description response-shape contract after one explicit retry; runtime verification is pending. Its dependency audit is deferred under the existing vulnerability issue. Installation PRs require human merge. This PR does not publish a release, tag or deployment.
The SDD, catalog, tests and user/operator documentation cover configuration reuse, access, additive grants, recovery, installer ownership, runner preservation and source compatibility.
Closes #538.
Fixes #547.