Skip to content

Add {cli} to maptiler_sytle() so that the link is properly formatted - #220

Closed
benjaminhlina wants to merge 2 commits into
walkerke:mainfrom
benjaminhlina:main
Closed

benjaminhlina wants to merge 2 commits into
walkerke:mainfrom
benjaminhlina:main

Conversation

@benjaminhlina

Copy link
Copy Markdown

Fixes issue #219

@walkerke

Copy link
Copy Markdown
Owner

Thanks so much for catching this, @benjaminhlina! I'd rather not add {cli} as a hard dependency for one message, so I fixed it by rewording the message so the URL isn't followed by a comma. That'll be on main shortly. Closing this in favor of that fix, but I really appreciate the report and the PR.

@walkerke walkerke closed this Sep 30, 2026
@benjaminhlina

benjaminhlina commented Oct 1, 2026 •

Copy link
Copy Markdown
Author

Yeah totally understandable as it's unnecessary for a single message. Is there a specific reason why you've chosen {rlang} over {cli} for messages and errors? This is out curiosity, as I often gravitate towards {cli} but wonder if there's advantages that {rlang} provides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants