fix(i18n): split locale catalogs and address #81 review feedback - #85
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Move EN/zh-CN strings into dedicated message modules, derive the runtime message map from the English catalog, restore browse CTA styling and singular word counts, and wire emitters to catalog strings to prevent drift. Co-authored-by: Wassim Gharbi <wassgha@gmail.com>
Co-authored-by: Wassim Gharbi <wassgha@gmail.com>
Co-authored-by: Wassim Gharbi <wassgha@gmail.com>
Make UI locale registration data-driven, detect Traditional Chinese / Japanese / Korean / Spanish / French / German from the system language list, and ship matching renderer + Electron catalogs plus NSIS languages. Co-authored-by: Wassim Gharbi <wassgha@gmail.com>
cursor
Bot
force-pushed
the
cursor/i18n-fixes-c54c
branch
from
August 12, 2026 04:49
f315a08 to
5686aff
Compare
wassgha
marked this pull request as ready for review
August 12, 2026 04:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #81 (now merged): review fixes, split locale catalogs, and expand beyond English/Chinese.
Rebased onto latest
main.Multi-locale support
Supported UI locales (with system detection):
en)zh-CN) —zh,zh-Hans, …zh-TW) —zh-TW,zh-HK,zh-MO,zh-Hantja)ko)es)fr)de)Detection walks
navigator.languages/app.getLocale()and picks the first supported tag. Settings lists every locale by native endonym; “System” follows the OS/browser list.Adding another language is mostly: append to
UI_LOCALESinlib/i18n/locales.ts, addmessages/<id>.ts+electron/locale/<id>.ts, register in the catalog maps.Also includes earlier #81 review fixes
en[...]Validation
npm run test:i18nnpx tsc --noEmitnpm run typecheck:electronnpm run lintnpm run build:electron