Repository navigation
Conversation
kreneskyp
marked this pull request as ready for review
October 14, 2026 20:03
Member
|
From other PRs by account this appears to be fully-automated AI submissions. Come back with a human touch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs IR-783.
Add a safe std
KillOnDropmarker that opts a WindowsJobObjectinto kill-on-close. Keep the existing std behavior unchanged when the marker is absent; the existing suspended spawn, job assignment, and resume sequence remains in place. The option works in either wrapper registration order.The Windows integration tests check default behavior, opt-in termination of a child and descendant when the wrapper is dropped, and that failed job assignment terminates the suspended child before its marker command runs.
Local macOS checks:
cargo fmt --checkpassed.cargo test --locked --features std --all-targetspassed (55 tests).cargo test --locked --no-default-features --features std --all-targetspassed (31 tests).cargo test --locked --all-features --all-targetspassed.cargo clippy --locked --features stdpassed with an existing unused-import warning insrc/std/core.rs.cargo check --locked --no-default-features --libpassed.std_windowstest target cross-compiles with rustup stable on macOS; this is compile evidence, not runtime execution.Native Windows execution and CI are pending.