-
-
Notifications
You must be signed in to change notification settings - Fork 26
Prevent validation report paths from overwriting compiler inputs #811
Copy link
Copy link
Closed
Labels
bugA problem that causes incorrect behavior or crashes.A problem that causes incorrect behavior or crashes.help wantedThe issue requires extra attention or help from others.The issue requires extra attention or help from others.needs testingIssues that require additional testing or verification.Issues that require additional testing or verification.
Description
Activity
Metadata
Metadata
Assignees
Labels
bugA problem that causes incorrect behavior or crashes.A problem that causes incorrect behavior or crashes.help wantedThe issue requires extra attention or help from others.The issue requires extra attention or help from others.needs testingIssues that require additional testing or verification.Issues that require additional testing or verification.
Problem
A report path can alias a Wave input or the selected compiler. Both runners write an initial JSON report before launching compilation. A mistaken
--report-jsoncan therefore destroy the source or compiler and make the subsequent checks operate on the replacement JSON.Starting points: tools/check_case_sources.py, tools/run_runtime_cases.py.
Reproduction
Executed on Linux amd64 with Python 3.14.7. The affected files at local
ade878134519b0f957ca28a23c6f9cd98e43dff3are byte-identical to canonical master286dad9c8fcb0616f7c719c72cbf453a7d9925fd.This reproduction uses only a temporary source and a mocked compiler:
Observed:
source replaced with JSON: True. The same write-before-input-validation ordering inrun_runtime_cases.executewas confirmed by source inspection, not a separate destructive CLI run.Scope
Moderate: validate report/input aliases before the first report write, covering selected sources and compiler executables in both runners. Include normalized paths and filesystem aliases. Related compiler-output protection in #745 does not protect these Python report writers.
Completion criteria