Repository navigation
Conversation
…es, UpdateHFresh) - VectorIndexFilterStrategy.Pathseer (Weaviate 1.40) - VectorIndex.None for a vector whose index was dropped: read back, sent back unchanged on update, left out on create, typed updates throw - VectorIndexConfigUpdate.UpdateHFresh: MaxPostingSizeKb, SearchProbe and the RQ RescoreLimit through a nested QuantizerConfigUpdateRQ - [Obsolete] on ReplicationConfig.AsyncEnabled, wire unchanged
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 49.7%
Weaviate.Client.Analyzers - 0%
Weaviate.Client.VectorData - 50.3%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection config changes for the Weaviate 1.40 companion release, mirroring Python 4.24.
Pathseer.
VectorIndexFilterStrategy.Pathseerfor the new HNSW filter strategy. Reading a collection that opted in used to throw in the strict enum converter. Requires Weaviate 1.40.Dropped vector indexes. A vector dropped with
DeleteVectorIndexstays in the schema asvectorIndexType: "none"until the server's cleanup task removes it. The client now reads it back asVectorIndex.None, sends it back unchanged onConfig.UpdateandAddVector, and leaves it out of a create built from an exported config. Typed updates on it (UpdateHNSWand friends) throw a clear error instead of "not of type HNSW". Before this change a full update re-sentvectorIndexConfig: {}, which the server rejects with 422 while cleanup runs and which revived the vector afterwards. The integration fixture inserts 3000 objects so the cleanup window is open during the test. That test fails on main.UpdateHFresh.
VectorIndexConfigUpdate.UpdateHFreshwithMaxPostingSizeKb,SearchProbeandQuantizer.RescoreLimit. The quantizer is a nested getter-onlyQuantizerConfigUpdateRQthat edits the existing RQ config in place. On 1.40 the server applies onlysearchProbeandrq.rescoreLimiton an HFresh update and never reads the other RQ fields for HFresh, so nothing else is exposed. More fields can be added later without breaking callers.AsyncEnabled.
[Obsolete]onReplicationConfig.AsyncEnabledand the update wrapper. Weaviate 1.38 and later ignore the field. The wire is unchanged so older servers still get it.Tests were run locally against 1.37.16, 1.38.9, 1.39.3 and 1.40.2. The Pathseer test is gated on 1.40.0 and skips on the current CI matrix. The CI matrix bump to 1.40.2 is a separate PR.