Repository navigation
Conversation
…ion) - protos resynced to v1.40.2, adding BatchDeleteReply.limit - DeleteManyResult.Limit: the per-call delete cap, null before 1.40 - VectorSearchInput.Combine throws when vector names differ from the target vectors, like the Python client
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 49.8%
Weaviate.Client.Analyzers - 0%
Weaviate.Client.VectorData - 50.3%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC changes for the Weaviate 1.40 companion release.
Protos resynced to v1.40.2 with
tools/proto_sync.sh. The one semantic change isBatchDeleteReply.limit. The batch.proto diff is comment-only and comes from upstream verbatim.DeleteManyResult.Limit. The server's per-call delete cap (QUERY_MAXIMUM_RESULTS), reported by Weaviate 1.40 and later, null on older servers.Matches > Limitmeans the call was capped and more objects still match. Note that a capped reply reportsMatchesas limit plus one rather than the full count, which is how the server counts (adapters/repos/db/batch.go). Verified on a 1.40.2 server with the cap set to 5: three rounds of 6/5, 6/5, 2/2 over 12 objects.VectorSearchInput.Combinevalidation. ThrowsArgumentExceptionwhen the vector names do not match the target vectors, the same check the Python client does. Before, a mismatch was sent as is and the server retargeted silently. Order does not matter.Tests were run locally against 1.37.16, 1.38.9, 1.39.3 and 1.40.2. The
Limitassertion in the batch delete test is version-gated and covers both the present and absent cases across the matrix.