Repository navigation
ci: test against Weaviate 1.40.0 and prepare the 4.24.0 changelog - #2201
Merged
Merged
Conversation
Add 1.40.0 to the matrix and bump 1.39 and 1.38 to their latest patches. The shards test compared per_node_status keys, which 1.40 populates, so compare its values. Servers from 1.38.19, 1.39.10 and 1.40.0 reject an empty alias pattern, so drop the role case that relied on it. Default embedded instances to 1.40.0, bump the authlib dev pin to the package requirement, and write the 4.24.0 changelog section.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The journey matrix runs Python 3.11 five times instead of testing its declared Python versions.
3 open findings
What changed in this PR
Updates CI and embedded defaults for Weaviate 1.40.0 and prepares the 4.24.0 changelog.
Changes:
- Adds Weaviate 1.40.0 CI coverage.
- Updates compatibility tests and development dependencies.
- Documents the 4.24.0 release.
| File | Description |
|---|---|
.github/workflows/main.yaml |
Updates Weaviate test versions and matrices. |
docs/changelog.rst |
Adds the 4.24.0 release notes. |
integration/test_collection_config.py |
Correctly checks per-node status values. |
integration/test_rbac.py |
Removes an invalid empty-alias test case. |
requirements-devel.txt |
Updates the Authlib development pin. |
weaviate/embedded.py |
Defaults embedded instances to Weaviate 1.40.0. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dirkkul
reviewed
Oct 13, 2026
dirkkul
approved these changes
Oct 14, 2026
Keep main's released 4.24.0 changelog and note the embedded 1.40.1 default under 4.24.1.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 312 312
Lines 24715 24715
=======================================
+ Hits 22054 22055 +1
+ Misses 2661 2660 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dirkkul
approved these changes
Oct 26, 2026
Keep the embedded 1.40.2 line alongside the 4.24.1 changelog from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matrix adds 1.40.0 and bumps 1.39 to 1.39.10 and 1.38 to 1.38.20; integration, journey and pyodide jobs run on 1.40.0. Two tests needed changes for current servers: the shards test compared
per_node_statuskeys (1.40 populates the map), and servers from 1.38.19, 1.39.10 and 1.40.0 reject an empty alias name in a permission, so that role case is dropped. Embedded instances default to 1.40.0 (theintegration_embeddedsuite passes locally and reports 1.40.0). Theauthlibdev pin now satisfies the package requirement.Writes the full 4.24.0 changelog section for everything merged since 4.23.1, including the lines for the HFresh read fix and the shard statuses, so this one merges last. The 1.36.9 minimum-version line stays with #2197. Split from #2190.