feat(core)!: enable createRequire parser by default - #1814
Open
elecmonkey wants to merge 3 commits into
Open
Conversation
elecmonkey
marked this pull request as draft
July 30, 2026 08:21
elecmonkey
marked this pull request as ready for review
July 30, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Rspack's
createRequireparser by default so Rslib can statically analyze and bundlecreateRequire()calls.The ESM and CJS outputs in the
tests/integration/shims/cjscase remain correct and preserve the expected module semantics.Breaking Change
Static dependencies loaded through
createRequire()are now bundled instead of being preserved for runtime resolution. Settools.rspack.module.parser.javascript.createRequiretofalseto restore the previous behavior.Output Changes
For static
createRequire()calls, the dependency is bundled and the call is replaced with__webpack_require__().In the shims integration case:
"use strict"to the ESM module factory instead of the entire chunk, preserving the original non-strict CommonJS semantics.Related Links