fix: replace deprecated url.parse() with new URL()#945
Closed
mriganshu16 wants to merge 1 commit into
Closed
Conversation
janvorwerk
reviewed
May 11, 2026
| @@ -1,3 +1,3 @@ | |||
| 'use strict'; | |||
|
|
|||
| const url = require('url'); | |||
There was a problem hiding this comment.
Hi @mriganshu16, can you update the PR?
|
Bump, this should get merged |
Member
|
This was done in #948. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 24 throws a deprecation warning (DEP0169) when url.parse()
is used. This replaces the two usages of url.parse() in web-push-lib.js
with the modern WHATWG URL API (new URL()), which is the recommended
replacement.
Fixes the issue reported in #943