Skip to content

Fix Windows HUD native popup click handling#620

Draft
LILQK wants to merge 1 commit into
webadderallorg:mainfrom
LILQK:fix-windows-hud-popup-clicks
Draft

Fix Windows HUD native popup click handling#620
LILQK wants to merge 1 commit into
webadderallorg:mainfrom
LILQK:fix-windows-hud-popup-clicks

Conversation

@LILQK
Copy link
Copy Markdown

@LILQK LILQK commented May 29, 2026

Summary

Fixes Windows native popup/file-picker click handling by removing the fullscreen transparent HUD passthrough path on Windows. Windows now uses the compact HUD fallback, so the topmost transparent overlay no longer spans the desktop and cannot interfere with native popups. The fallback HUD bounds were tightened to reduce the transparent area around the controls and popovers.

Root Cause

On Windows, the HUD could be a transparent always-on-top window covering the full work area while relying on setIgnoreMouseEvents(true, { forward: true }). Native popups and file picker dialogs are sensitive to focus/z-order changes, and this fullscreen topmost overlay could prevent them from receiving clicks.

Changes

  • Treat Windows as compact-HUD-only instead of fullscreen passthrough HUD.
  • Gate renderer mouse passthrough tracking so it only runs on platforms that use passthrough.
  • Tighten compact and expanded fallback HUD bounds.
  • Update HUD bounds tests for the new fallback geometry.

Validation

  • npx biome check electron/hudOverlayBounds.ts electron/hudOverlayBounds.test.ts electron/windows.ts src/components/launch/LaunchWindow.tsx src/components/launch/hooks/useLaunchHudInteractionState.ts
  • npx tsc --noEmit
  • npx vitest --run electron/hudOverlayBounds.test.ts src/components/launch/hudMousePassthrough.test.ts
  • Built a Windows installer with npm run build:win
  • Manually verified on Windows 11 that native popups/file picker interactions can be clicked while Recordly is open.

Platform Testing Note

This has only been tested on Windows 11. It has not been tested on macOS, Linux, Windows 10, or other Windows versions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bb9624d8-ebb6-4161-9e85-96b2f7e5f8b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant