Fix Windows HUD native popup click handling#620
Draft
LILQK wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows native popup/file-picker click handling by removing the fullscreen transparent HUD passthrough path on Windows. Windows now uses the compact HUD fallback, so the topmost transparent overlay no longer spans the desktop and cannot interfere with native popups. The fallback HUD bounds were tightened to reduce the transparent area around the controls and popovers.
Root Cause
On Windows, the HUD could be a transparent always-on-top window covering the full work area while relying on
setIgnoreMouseEvents(true, { forward: true }). Native popups and file picker dialogs are sensitive to focus/z-order changes, and this fullscreen topmost overlay could prevent them from receiving clicks.Changes
Validation
npx biome check electron/hudOverlayBounds.ts electron/hudOverlayBounds.test.ts electron/windows.ts src/components/launch/LaunchWindow.tsx src/components/launch/hooks/useLaunchHudInteractionState.tsnpx tsc --noEmitnpx vitest --run electron/hudOverlayBounds.test.ts src/components/launch/hudMousePassthrough.test.tsnpm run build:winPlatform Testing Note
This has only been tested on Windows 11. It has not been tested on macOS, Linux, Windows 10, or other Windows versions.