revert: undo PRs 625 and 626#627
Closed
meiiie wants to merge 1 commit into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reverts the runtime changes from:
fix(audio): preserve mac sidecar track controlsfix(linux): stabilize portal source selection HUDI intentionally did not include #624 in this revert PR. I tested reverting #624 as well, but that PR is mostly baseline/test alignment plus a small preset-persistence fix; reverting it makes the current test suite fail against the current runtime contracts (
cursorStyledefault, webcam render-source tests, audiomainBufferEntrycontract, and fallback import timing). Keeping #624 avoids turning this revert into a test-baseline regression.Why
Recent user reports suggest v1.3.3 may have introduced regressions around editor/audio/HUD behavior. This PR is a conservative rollback of the two runtime patches most likely to affect those areas, while keeping the verified baseline cleanup from #624.
Validation
git diff --cached --checknpx tsc --noEmitnpx biome check electron/electron-env.d.ts electron/hudOverlayBounds.test.ts electron/hudOverlayBounds.ts electron/ipc/recording/mac.ts electron/preload.ts electron/windows.ts src/components/video-editor/timeline/TimelineEditor.tsx src/components/video-editor/timeline/hooks/useTimelineAudioPeaks.ts src/hooks/useScreenRecorder.test.ts src/hooks/useScreenRecorder.ts src/lib/exporter/audioEncoder.test.ts src/lib/exporter/audioEncoder.tsnpx vitest run electron/hudOverlayBounds.test.ts src/hooks/useScreenRecorder.test.ts src/lib/exporter/audioEncoder.test.ts src/components/video-editor/editorPreferences.test.ts src/lib/exporter/modernFrameRenderer.test.ts src/lib/exporter/modernVideoExporter.fallback.test.ts --reporter=verbosenpm test(87files,767tests passed)Notes
npm run build:winwas attempted, but it exceeded the 5-minute local timeout before completion, so it is not counted as passed validation.