Skip to content

revert: undo PRs 625 and 626#627

Closed
meiiie wants to merge 1 commit into
mainfrom
revert/pr-625-626
Closed

revert: undo PRs 625 and 626#627
meiiie wants to merge 1 commit into
mainfrom
revert/pr-625-626

Conversation

@meiiie
Copy link
Copy Markdown
Collaborator

@meiiie meiiie commented May 29, 2026

Summary

This reverts the runtime changes from:

I intentionally did not include #624 in this revert PR. I tested reverting #624 as well, but that PR is mostly baseline/test alignment plus a small preset-persistence fix; reverting it makes the current test suite fail against the current runtime contracts (cursorStyle default, webcam render-source tests, audio mainBufferEntry contract, and fallback import timing). Keeping #624 avoids turning this revert into a test-baseline regression.

Why

Recent user reports suggest v1.3.3 may have introduced regressions around editor/audio/HUD behavior. This PR is a conservative rollback of the two runtime patches most likely to affect those areas, while keeping the verified baseline cleanup from #624.

Validation

  • git diff --cached --check
  • npx tsc --noEmit
  • npx biome check electron/electron-env.d.ts electron/hudOverlayBounds.test.ts electron/hudOverlayBounds.ts electron/ipc/recording/mac.ts electron/preload.ts electron/windows.ts src/components/video-editor/timeline/TimelineEditor.tsx src/components/video-editor/timeline/hooks/useTimelineAudioPeaks.ts src/hooks/useScreenRecorder.test.ts src/hooks/useScreenRecorder.ts src/lib/exporter/audioEncoder.test.ts src/lib/exporter/audioEncoder.ts
  • npx vitest run electron/hudOverlayBounds.test.ts src/hooks/useScreenRecorder.test.ts src/lib/exporter/audioEncoder.test.ts src/components/video-editor/editorPreferences.test.ts src/lib/exporter/modernFrameRenderer.test.ts src/lib/exporter/modernVideoExporter.fallback.test.ts --reporter=verbose
  • npm test (87 files, 767 tests passed)

Notes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 82a1ee15-9606-4bd2-b14b-ee620a5b2613

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/pr-625-626

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@meiiie meiiie closed this May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant