test(backend): cover Preserve & Rerun across the run boundary - #326
Merged
Conversation
Greptile SummaryThis PR adds backend integration coverage for Preserve & Rerun across newly spawned run identities and documents the behavior for the Python Selenium adapter.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the newly added sibling-preservation scenario resolves the previously reported coverage gap by failing if the rerun worker is handled as an ordinary new run.
|
| Filename | Overview |
|---|---|
| packages/backend/tests/preserve-across-rerun.test.ts | Adds deterministic end-to-end backend coverage using the real runner path, including a sibling-preservation assertion that distinguishes rerun-child continuity from an ordinary new-run reset. |
| packages/selenium-devtools-py/README.md | Documents Preserve & Rerun behavior and updates the implementation roadmap consistently with the covered backend behavior. |
| CLAUDE.md | Records the capability-gate and baseline-lifecycle rationale behind Preserve & Rerun. |
Sequence Diagram
sequenceDiagram
participant W1 as Original worker
participant B as Backend
participant R as Test runner
participant W2 as Rerun worker
W1->>B: Report failed attempt and sibling
B->>B: Preserve selected baseline
B->>R: Request rerun with preserveBaseline
R->>R: Arm rerun-child state and spawn process
W2->>B: Connect with new run ID
B->>B: Consume rerun-child state without resetting active run
W2->>B: Report rerun attempt
B-->>W2: Baseline and latest remain comparable
Reviews (2): Last reviewed commit: "test(backend): drive the real rerun-chil..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Type of change
Packages touched
shared(types and contracts)core(framework-agnostic capture/reporting)elements(published element/snapshot API —@wdio/elements)service(WebdriverIO adapter)nightwatch-devtools(Nightwatch adapter)selenium-devtools(Selenium adapter)backend(server)app(UI)script(page-injected runtime)selenium-devtools-pyNotes for reviewers
Screenshots / recordings