Repository navigation
Fire toolactivated after invoking execute - #371
Open
beaufortfrancois wants to merge 1 commit into
Open
beaufortfrancois wants to merge 1 commit into
beaufortfrancois wants to merge 1 commit into
Conversation
Fires the toolactivated event after invoking the tool's execute callback, so listeners observe the tool's synchronous effects. This matches Chromium and WPT. Fixes webmachinelearning#332
Collaborator
|
@sjdallst2, do you want to take a first pass at this PR? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fires the
toolactivatedevent after invoking the tool'sexecutecallback, so listeners observe the tool's synchronous effects (e.g. a filled-in declarative form). This matches Chromium and WPT (executeTool-abort.https.html).No explicit fully active guard is needed: if
executedetaches the document, DOM's inner invoke already skips listeners when the target's relevant global object's associated Document is not fully active, matchingexecuteTool-detach-toolactivated.https.html.Fixes #332
Preview | Diff