fix: make progress indicators interruption-safe - #5726
Conversation
🦋 Changeset detectedLatest commit: c1e5eaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe Merge Risk: ⚪ Minimal · up to The PR makes localized progress-indicator lifecycle, accessibility, and reduced-motion improvements without changing public APIs or runtime dependencies. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
client-src/progress.jsESLint failed to execute (timeout). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes
Compatibility
No public API, dependency or engine change. Completion still takes 800 ms (500 ms pause plus 300 ms fade); reduced motion removes animation but retains the completion delay. Initial circular zero progress is visible as the start of a build.
Motion review
Verdict: Approve — no motion blocker found in the reviewed paths. Native CSS supplies the visual effect; no animation package added.
Verification
Standalone controls cover pre-connection attributes, stable DOM identity, linear/circular interruption, both timer cleanup paths and reduced-motion CSS. Browser checks confirm a visible 30% linear bar and 40% circular indicator after immediate restart. Combined client diagnostic suite: 30 pass; existing client suites, build, lint and types pass.
Audit scope
This is a focused, independently based change from a broader source review at f804962. The combined frozen-source run executed 1,002 tests: 951 passed, 43 failed, one cancelled, seven skipped. Failures were traced to the separately proposed overlay DOM snapshots, reconnect-disabled test expectation and IPv6 host-test assumptions; it is not represented as a green full suite. Relevant focused results are listed above. No checked-in tests/specs/snapshots were added or modified. Hosted CI and the full OS/Node matrix remain pending.
Summary by CodeRabbit
Accessibility
Improvements