Repository navigation
test: give each reload test file its own CSS fixture - #5788
Conversation
`api-plugin`, `event-source` and `hot-and-live-reload` all rewrote `test/fixtures/reload-config/main.css`, and `node --test` runs files in parallel, so a test could see another file's colour or an extra rebuild. Give `api-plugin` and `event-source` their own copies, as `progress` already does with `reload-config-2`. Claude-Session: https://claude.ai/code/session_013FhutSnStkMpV2mZSNb8M9
|
|
No actionable comments were generated in the recent review.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5788 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 6 6
Lines 5551 5551
=======================================
Hits 5318 5318
Misses 233 233 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
test/e2e/api-plugin.test.js,event-source.test.jsandhot-and-live-reload.test.jsall rewritetest/fixtures/reload-config/main.css, andnode --testruns files in parallel. One file can then see another's colour, or an extra rebuild from another's write. Both failures below are from Windows CI on #5787, which touches none of these tests:hot-and-live-reload.test.js:308api-plugin.test.js:846rgb(255, 0, 0)before the test changed anything; itsbeforeEachhad just written blueThis gives
api-pluginandevent-sourcetheir own copies (reload-config-3,reload-config-4), asprogress.test.jsalready does withreload-config-2.hot-and-live-reloadkeepsreload-config, so its snapshots don't change.What kind of change does this PR introduce?
test
Did you add tests for your changes?
No new tests: it only changes test fixtures.
api-plugin.test.jsandevent-source.test.jspass locally.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
n/a
Use of AI
Claude Code traced the two CI failures to the shared fixture and made this change. It ran both changed test files and
npm run lintlocally.Generated by Claude Code
Summary by CodeRabbit