Repository navigation
Conversation
The loader and plugin pages are generated only for repositories that are not archived, so the index tables linked to pages that no longer exist. List the maintained packages, add diagnostics-webpack-plugin, and move the archived ones to a deprecated section that points to their replacements. Closes webpack#291
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
documentation
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Out of Scope Changes check |  |
The changes stay in the two index pages and follow the goal of #291. Two points lack evidence. (1) The plugins table removes mini-css-extract-plugin, copy-webpack-plugin, compression-webpack-plugin, i… |
Confirm the archive status of each removed plugin and loader repository, for example from the GitHub repository settings or org repository list. If an entry is not archived, restore its row. Update the PR description so that it matches head… |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: removing archived loaders and plugins from the documentation index pages. Linked Issues check [ #291] Requirement: the loaders and plugins index pages must not link to deprecated or archived repositories whose generated pages return 404. At head, pages/docs/loaders/index.md keeps 6 loader links…Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Full details: Linked Issues check
-
Explanation
[
#291] Requirement: the loaders and plugins index pages must not link to deprecated or archived repositories whose generated pages return 404. At head, pages/docs/loaders/index.md keeps 6 loader links (sass, less, stylus, postcss, coffee, thread) and removes the other 6 (css, style, html, exports, imports, expose). pages/docs/plugins/index.md keeps minimizer-webpack-plugin and adds diagnostics-webpack-plugin, and removes 6 entries. scripts/markdown/readmes.mjs skips repos where repo.archived is true, so pages exist only for non-archived org repos. The kept links therefore target generated pages. The change is docs-only and has no automated test. The removed links are no longer present. Archive status of the live repositories was not independently checked, because the tools cannot query GitHub. The PR description's 'Deprecated' sections and replacement guidance do not appear at head. They are not a requirement of#291, so this does not change the result.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Full details: Out of Scope Changes check
-
Explanation
The changes stay in the two index pages and follow the goal of
#291. Two points lack evidence. (1) The plugins table removes mini-css-extract-plugin, copy-webpack-plugin, compression-webpack-plugin, image-minimizer-webpack-plugin, eslint-webpack-plugin, and stylelint-webpack-plugin. The PR description names replacements only for copy, eslint, and some others. It does not state that mini-css-extract-plugin is archived, and the script filter alone cannot show that. Removing an active, non-archived package would exceed#291, which covers only deprecated or archived repositories. (2) The PR description says 'Deprecated' sections with replacements were added. The head diff contains no such sections, so the description does not match the code. The author credit change (samc4e) is minor metadata for the same pages and is not treated as unrelated.Resolution
Confirm the archive status of each removed plugin and loader repository, for example from the GitHub repository settings or org repository list. If an entry is not archived, restore its row. Update the PR description so that it matches head. State the replacement guidance that is kept or dropped for each removed package. Then reassess this check.
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
c50d30d8-4538-4f02-974c-25433c23ee84
-
pages/docs/loaders/index.mdpages/docs/plugins/index.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
-
Not every deprecated loader is replaced by webpack itself, and eslint-webpack-plugin was renamed rather than archived.
|
@ryzrr PTAL |
i think we dont need to mention the deprecated list on the index page
|
okay I will make it in single list |
Keep each index page to the single list of maintained packages, as requested in review.
Closes #291
Summary
scripts/markdown/readmes.mjsskips archived repositories, so no pages are generated for the loaders and plugins the webpack org has archived. The hand-written index tables still linked to them, which made 13 of the 19 links 404.Changes
sass,less,stylus,postcss,coffee,thread).minimizer-webpack-pluginand adddiagnostics-webpack-plugin(the renamedeslint-webpack-plugin).experiments.html,output.copy,minimizer-webpack-plugin, ordiagnostics-webpack-plugin.copy-webpack-pluginpoints tooutput.copywithout a link, because the API reference is built from 5.109.2 and that option arrived in 5.111.0.Before:
After :
Screencast from 28-10-26 02:44:45 AM IST.webm
Not in this PR
readmes.mjswould stop them drifting again. Happy to do that in a follow-up if you want it.Testing
npm run build. All internal links and anchors on both index pages resolve inout/.npm run format:checkandnpm run lintpass.Use of AI
yes antigravity used ,for tracing the archived repository of specific plugin.
Summary by CodeRabbit
css-loader,style-loader,html-loader,exports-loader,imports-loader, orexpose-loader.minimizer-webpack-pluginanddiagnostics-webpack-plugin, and no longer listsmini-css-extract-plugin,copy-webpack-plugin,compression-webpack-plugin,image-minimizer-webpack-plugin,eslint-webpack-plugin, orstylelint-webpack-plugin.