feat: send the caller identification in the User-Agent - #2
Merged
Merged
Conversation
othercodes
requested review from
frgtn,
gmunguia,
laureenas,
meznaric and
tehnuty
September 28, 2026 16:35
meznaric
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caller identification moves from
X-Webshare-SourceintoUser-Agent, which now leads with the product token and ends with the library:WebshareSDK/0.1.1 (Python; 3.12.8) webshare-python/0.1.1. That is what RFC 9110 designs the header for, and it lets the API tell a tool built on the SDK from a plain SDK call while keeping the library version in the same string.The
sourceclient option keeps its name and still replaces the product token. The old header is no longer sent.