Skip to content

feat: add forward option when sharing assets [WPB-26687]#4869

Open
MohamadJaara wants to merge 7 commits into
developfrom
mo/feat/share-logs-as-one-file
Open

feat: add forward option when sharing assets [WPB-26687]#4869
MohamadJaara wants to merge 7 commits into
developfrom
mo/feat/share-logs-as-one-file

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented May 26, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-26687

Summary

Adds a “Share in Wire” option alongside the existing external sharing flow for logs and shared assets.

This PR builds on the zipped-log sharing work and extends the sharing UX so users can choose whether to share content inside Wire or through external apps.

Changes

  • Add separate sharing actions for:
    • sharing logs via Wire
    • sharing logs externally
  • Add a share-options bottom sheet for log sharing.
  • Route Wire log sharing through ImportMediaScreen using shared file URIs.
  • Keep external sharing behind the system chooser and exclude Wire’s own share targets.
  • Introduce ImportMediaNavArgs for passing shared media URIs through navigation.
  • Update asset/message/gallery sharing flows to support both Wire and external destinations.
  • Rework log archive sharing helpers so zipped logs can be shared either as an external intent or as a Wire-import URI.
  • Add/update tests around log zip creation and media sharing behavior.

@MohamadJaara MohamadJaara force-pushed the mo/feat/share-logs-as-one-zip-file branch from 9846e21 to f051666 Compare June 24, 2026 11:42
Base automatically changed from mo/feat/share-logs-as-one-zip-file to develop June 24, 2026 12:42
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara force-pushed the mo/feat/share-logs-as-one-file branch from ad612e0 to a60da89 Compare June 24, 2026 19:25
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.36318% with 146 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.22%. Comparing base (1e55dfd) to head (d4ad5d2).

Files with missing lines Patch % Lines
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% 59 Missing ⚠️
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 51.85% 20 Missing and 6 partials ⚠️
.../com/wire/android/feature/cells/util/FileHelper.kt 0.00% 12 Missing ⚠️
...e/android/ui/home/gallery/MediaGalleryViewModel.kt 38.88% 11 Missing ⚠️
...kotlin/com/wire/android/util/logging/LogSharing.kt 0.00% 11 Missing ⚠️
...otlin/com/wire/android/ui/WireActivityViewModel.kt 76.47% 0 Missing and 4 partials ⚠️
...n/com/wire/android/ui/edit/ShareAssetMenuOption.kt 0.00% 4 Missing ⚠️
.../com/wire/android/ui/WireActivityActionsHandler.kt 0.00% 3 Missing ⚠️
...nversations/edit/MessageOptionsModalSheetLayout.kt 0.00% 3 Missing ⚠️
...rsations/messages/ConversationMessagesViewModel.kt 0.00% 3 Missing ⚠️
... and 6 more

❌ Your patch check has failed because the patch coverage (27.36%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4869      +/-   ##
===========================================
- Coverage    49.31%   49.22%   -0.10%     
===========================================
  Files          650      652       +2     
  Lines        23457    23593     +136     
  Branches      3606     3642      +36     
===========================================
+ Hits         11568    11613      +45     
- Misses       10813    10893      +80     
- Partials      1076     1087      +11     
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 56.48% <ø> (ø)
.../wire/android/mapper/SystemMessageContentMapper.kt 47.30% <87.50%> (ø)
...ndroid/ui/sharing/ImportMediaAuthenticatedState.kt 87.50% <0.00%> (ø)
...kotlin/com/wire/android/util/AvatarImageManager.kt 0.00% <0.00%> (ø)
...kotlin/com/wire/android/ui/MiscViewModelFactory.kt 0.00% <0.00%> (ø)
...ain/kotlin/com/wire/android/ui/debug/LogOptions.kt 0.00% <0.00%> (ø)
.../com/wire/android/ui/WireActivityActionsHandler.kt 0.00% <0.00%> (ø)
...nversations/edit/MessageOptionsModalSheetLayout.kt 1.92% <0.00%> (-0.08%) ⬇️
...rsations/messages/ConversationMessagesViewModel.kt 68.42% <0.00%> (-1.00%) ⬇️
...om/wire/android/ui/userprofile/qr/QRCodeIntents.kt 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e55dfd...d4ad5d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara force-pushed the mo/feat/share-logs-as-one-file branch from 763179b to 9669177 Compare June 30, 2026 10:50
@MohamadJaara MohamadJaara changed the title feat: add forward option when sharing assets feat: add forward option when sharing assets [WPB-26687] Jun 30, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant