Skip to content

test: e2e test helper refactor (WPB-26603)#5013

Open
emmaoke-w wants to merge 5 commits into
developfrom
test/WPB-26603-e2e-test-helper-refactor
Open

test: e2e test helper refactor (WPB-26603)#5013
emmaoke-w wants to merge 5 commits into
developfrom
test/WPB-26603-e2e-test-helper-refactor

Conversation

@emmaoke-w

@emmaoke-w emmaoke-w commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-26603


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Refactored TestServiceHelper so it stays focused on actions that go through the Test Service, instead of also owning backend setup flows.
  • Refactored UIAutomator tests to use one shared ClientUserManager across backend setup, Test Service actions, calling helpers, and teardown cleanup.
  • Refactored BackendClient helper logic into focused backend extension files for auth, users, teams, conversations, connections, client/device cleanup, SSO, and calling.
  • Refactored backend state preparation into a new BackendSetupHelper for users, teams, conversations, connections, team features, and bots.
  • Refactored benchmark startup fixture setup to use ClientUserManager and BackendSetupHelper, matching the updated UI test infrastructure.

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@emmaoke-w emmaoke-w marked this pull request as ready for review June 30, 2026 15:43
@emmaoke-w emmaoke-w requested review from Garzas and yamilmedina June 30, 2026 15:44
Comment thread tests/testsSupport/src/main/service/TestServiceHelper.kt Outdated
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.33%. Comparing base (49e7100) to head (e8c8bf9).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5013      +/-   ##
===========================================
+ Coverage    49.31%   49.33%   +0.02%     
===========================================
  Files          650      653       +3     
  Lines        23457    23512      +55     
  Branches      3606     3607       +1     
===========================================
+ Hits         11568    11600      +32     
- Misses       10813    10839      +26     
+ Partials      1076     1073       -3     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e7100...e8c8bf9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emmaoke-w emmaoke-w force-pushed the test/WPB-26603-e2e-test-helper-refactor branch from 031e2b8 to e8c8bf9 Compare June 30, 2026 18:03
@emmaoke-w emmaoke-w requested a review from yamilmedina June 30, 2026 18:04
@sonarqubecloud

Copy link
Copy Markdown

@emmaoke-w emmaoke-w requested a review from MohamadJaara June 30, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants