Skip to content

feat(drive): preserve selected sort state when entering search screen (WPB-26232) - #5150

Open
ohassine wants to merge 2 commits into
developfrom
preserve-selected-sort-state-when-entering-search-screen
Open

feat(drive): preserve selected sort state when entering search screen (WPB-26232)#5150
ohassine wants to merge 2 commits into
developfrom
preserve-selected-sort-state-when-entering-search-screen

Conversation

@ohassine

@ohassine ohassine commented Aug 10, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-26232


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Preserve selected sort state when entering search screen

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.46%. Comparing base (9ac94a8) to head (01c8fb5).

Files with missing lines Patch % Lines
...feature/cells/ui/search/sort/SortCriteriaNavArg.kt 0.00% 23 Missing ⚠️
...d/feature/cells/ui/search/SearchScreenViewModel.kt 33.33% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (3.84%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5150      +/-   ##
===========================================
- Coverage    50.52%   50.46%   -0.06%     
===========================================
  Files          671      672       +1     
  Lines        24604    24629      +25     
  Branches      3832     3840       +8     
===========================================
  Hits         12430    12430              
- Misses       11029    11053      +24     
- Partials      1145     1146       +1     
Files with missing lines Coverage Δ
...d/feature/cells/ui/search/SearchScreenViewModel.kt 44.80% <33.33%> (-0.50%) ⬇️
...feature/cells/ui/search/sort/SortCriteriaNavArg.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac94a8...01c8fb5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 225 tests  ±0   2 225 ✅ ±0   1m 45s ⏱️ -2s
  241 suites ±0       0 💤 ±0 
  241 files   ±0       0 ❌ ±0 

Results for commit 01c8fb5. ± Comparison against base commit 9ac94a8.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine
ohassine requested review from a team, Garzas, sbakhtiarov and valerio-bettini and removed request for a team and valerio-bettini August 13, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants