Skip to content

feat: show security providers info screen (WPB-27916) - #5156

Open
ohassine wants to merge 6 commits into
developfrom
security-providers-info-screen
Open

feat: show security providers info screen (WPB-27916)#5156
ohassine wants to merge 6 commits into
developfrom
security-providers-info-screen

Conversation

@ohassine

@ohassine ohassine commented Aug 11, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-27916


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Show security providers info screen in debug settings screen

Screen_recording_20260811_122754.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine
ohassine requested review from a team, MohamadJaara and yamilmedina and removed request for a team August 11, 2026 13:09
…-info-screen

# Conflicts:
#	app/src/main/kotlin/com/wire/android/di/metro/WireMetroViewModelBindings.kt
#	app/src/main/kotlin/com/wire/android/ui/debug/DebugInfoViewModelFactory.kt
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.41%. Comparing base (1a626ed) to head (f1c344e).
⚠️ Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...oid/ui/debug/securityproviders/AppPathsProvider.kt 0.00% 16 Missing ⚠️
...ug/securityproviders/SecurityProvidersViewModel.kt 0.00% 10 Missing ⚠️
...oid/ui/debug/securityproviders/SecurityProvider.kt 0.00% 8 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5156      +/-   ##
===========================================
- Coverage    52.77%   52.41%   -0.36%     
===========================================
  Files          659      667       +8     
  Lines        23589    23846     +257     
  Branches      3881     3932      +51     
===========================================
+ Hits         12448    12499      +51     
- Misses        9994    10186     +192     
- Partials      1147     1161      +14     
Files with missing lines Coverage Δ
...oid/ui/debug/securityproviders/SecurityProvider.kt 0.00% <0.00%> (ø)
...ug/securityproviders/SecurityProvidersViewModel.kt 0.00% <0.00%> (ø)
...oid/ui/debug/securityproviders/AppPathsProvider.kt 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a626ed...f1c344e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 265 tests  +25   2 265 ✅ +25   2m 23s ⏱️ -3s
  250 suites + 5       0 💤 ± 0 
  250 files   + 5       0 ❌ ± 0 

Results for commit f1c344e. ± Comparison against base commit 1a626ed.

♻️ This comment has been updated with latest results.

@MohamadJaara

Copy link
Copy Markdown
Member

this will show all providers which is not the intendet behaivour
what is needed it to show the provider for each action
like when using SecureRandom() from kalium or the app waht is the provider at run time

@ohassine

Copy link
Copy Markdown
Member Author

this will show all providers which is not the intendet behaivour what is needed it to show the provider for each action like when using SecureRandom() from kalium or the app waht is the provider at run time

The ticket asks for a section that "displays entries for security providers," which is what this implements. the installed provider list with their entries

What you're describing is different. Happy to build it, but could you update the AC since the scope changed?

@ohassine
ohassine requested a review from yamilmedina August 12, 2026 07:40
@yamilmedina

yamilmedina commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

this will show all providers which is not the intendet behaivour what is needed it to show the provider for each action like when using SecureRandom() from kalium or the app waht is the provider at run time

The ticket asks for a section that "displays entries for security providers," which is what this implements. the installed provider list with their entries

What you're describing is different. Happy to build it, but could you update the AC since the scope changed?

Good point, my bad I oversaw some info, I've updated the ticket(s) with a couple of things to consider:

@pull-request-size pull-request-size Bot added size/S and removed size/M labels Aug 13, 2026
Comment thread app/src/main/res/values/strings.xml Outdated
<string name="debug_settings_force_repair_faulty_keys" translatable="false">Reset</string>
<string name="debug_settings_feature_flags" translatable="false">Feature Flags</string>
<string name="debug_settings_conversation_crypto_stats" translatable="false">Conversation Crypto Stats</string>
<string name="debug_settings_security_providers" translatable="false">Security Providers</string>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="debug_settings_security_providers" translatable="false">Security Providers</string>
<string name="debug_settings_security_providers" translatable="false">Security Diagnostics</string>

@yamilmedina yamilmedina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! just pls let's change the name of the Security providers item to Security Diagnostics before merging as indicated and be aligned with the docs/ticket :D

@pull-request-size pull-request-size Bot added size/M and removed size/S labels Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants