feat: update conversation name when updating meeting [WPB-27617] - #5172
Open
saleniuk wants to merge 5 commits into
Open
feat: update conversation name when updating meeting [WPB-27617]#5172saleniuk wants to merge 5 commits into
saleniuk wants to merge 5 commits into
Conversation
saleniuk
changed the title
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5172 +/- ##
===========================================
+ Coverage 52.74% 52.77% +0.02%
===========================================
Files 659 659
Lines 23618 23633 +15
Branches 3886 3888 +2
===========================================
+ Hits 12458 12472 +14
- Misses 10010 10011 +1
Partials 1150 1150
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
ohassine
reviewed
Aug 14, 2026
Comment on lines
+306
to
+309
| state = state.copy(isSubmitting = false, continueButtonEnabled = true) | ||
| when (it) { | ||
| is RenamingResult.Failure -> | ||
| state = state.copy(submitError = NewMeetingState.SubmitError.UpdateConversationNameFailure(conversationId)) |
Member
There was a problem hiding this comment.
In case of failure, continueButtonEnabled is set to true. Is that expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-27617
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Currently, when the meeting title is being updated, it's underlying meeting type conversation still keeps the original name so when the call starts, it can show the old name.
Solutions
Update the conversation name when meeting is updated. When it fails, we intentionally execute the persist action so that meeting is updated locally, but pass the error to the UI to be displayed to the user and then retried - it's not breaking issue if the names are out of sync, we want to keep all other meeting parameters up to date and give user option to retry.
In this PR this new type of error is handled by showing alert to the user with an option to retry- but retry only edits the conversation name.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Create a meeting, edit the title of the meeting, start a meeting call and check the name.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.