ci: sanitize Android UI workflow logs and remove column flavors (WPB-27951) - #5174
ci: sanitize Android UI workflow logs and remove column flavors (WPB-27951)#5174emmaoke-w wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5174 +/- ##
===========================================
- Coverage 52.75% 52.74% -0.01%
===========================================
Files 659 659
Lines 23599 23618 +19
Branches 3883 3886 +3
===========================================
+ Hits 12450 12458 +8
- Misses 10001 10010 +9
- Partials 1148 1150 +2 see 4 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
| @@ -0,0 +1,82 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
I don't think this is the right approach, while it might work in my opinion is too crafted/custom.
In practice this can be achieved by changing the LogLevel at WireTestLogger so we have less noise naturally or in AllureLogcatRule (which seems unused) by adding filters.
My point I guess is we are going to miss info, and logs don't harm/specially in testing; it is more an after processing/filtering concern, not about trimming the raw output.
There was a problem hiding this comment.
An option is to have this script, but run it manually on demand/locally to filter out noise, but not in the gh output.
https://wearezeta.atlassian.net/browse/WPB-27951
…27951)
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
S3_FOLDERonly to the APK download step instead of keeping it job-wide.Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.