Fix processor registration and subscription removal - #8346
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both processor stores remove subscriptions with
splice(index)and nodeleteCount. Removing one processor therefore removes it and every processor registered after it. Calling the same subscription twice can also pass-1and remove the last unrelated processor. Option processor paths additionally use a plain object registry, so valid public paths such astoStringand__proto__collide with inherited properties and fail during registration.Fix
Breaking changes
None. The change restores the documented subscription boundary and accepts previously broken string paths.
Test plan
toStringand__proto__option-path coverage.yarn test-jspasses: 38 suites, 401 tests; 11 suites/59 tests remain intentionally skipped.git diff --checkpass.Existing React act/deprecation warnings are unchanged.