fix(iOS): clean up screen animation mount observers - #8355
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and fix
ScreenAnimationControllerregistered itself for React Native mount notifications on every transition but never unregistered. Under the New Architecture,RCTSurfacePresenterstores observers in a weak vector whose dead entries are not compacted, so repeated navigation leaves an ever-growing list for every mount notification to scan.This change:
The legacy
RCTUIManagerObserverCoordinatorpath receives the same balanced lifecycle cleanup.Verification
build-for-testingsucceededScreenAnimationControllerTest: 1/1 passed on an iPhone 16 Pro simulator (iOS 26.5)git diff --checkpassedBreaking changes
None. This only balances internal observer registration and removal.