fix(Android): always release modal lifecycle listener - #8357
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and fix
ModalHostLayoutregisters itself as a React lifecycle listener during construction.ModalViewManager.onDropViewInstanceremoved that listener only insidenavigator?.let, so dropping a modal while there was no activeNavigationActivity/navigator left the discarded host registered withReactContext.This can occur while an activity is absent, finishing, or destroyed. The stale lifecycle registration retains unnecessary work and references after the React view has been dropped.
The cleanup now runs in
finally, preserving dismissal when a navigator exists while guaranteeingonDropInstance()when it does not—or if synchronous dismissal fails.Regression coverage
The new Robolectric test drops a modal with no active activity/navigator and verifies that its lifecycle listener is still removed. The exact baseline fails this assertion.
Verification
git diff --checkpassedBreaking changes
None. This guarantees existing teardown behavior on every drop path.