perf(Android): recycle replaced shadow bitmaps - #8360
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance problem and fix
ShadowLayoutregenerates its cached bitmap after layout/appearance changes. The previous bitmap was overwritten without being recycled, so each regeneration left its native pixel allocation for GC/finalization instead of releasing it deterministically. A full-screen-width shadow cache can make that churn substantial during repeated layout changes.This change centralizes cache teardown:
CanvasThe temporary alpha bitmap was already recycled and remains unchanged.
Regression coverage
The new Robolectric test renders a shadow, invalidates layout, renders again, and verifies the first bitmap was recycled before the replacement became active. The exact baseline leaves it unrecycled.
Verification
git diff --checkpassedBreaking changes
None. Rendering output is unchanged; native bitmap memory is released promptly.