fix(Android): close temporary image and theme resources - #8361
Open
OskarEichler wants to merge 1 commit into
Open
fix(Android): close temporary image and theme resources#8361OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems and fixes
The Android resource-lifecycle sweep found two temporary resources that were never closed:
InputStreamtoBitmapFactorywithout closing it. If opening or decoding threw, the temporary permissiveStrictModepolicy also remained installed on the calling thread.TypedArraywithout recycling it.This change uses
InputStream.use, rejects missing/undecodable streams through the existing error path, restores the original thread policy infinally, and recycles the typed array infinally.Regression coverage
The new Robolectric regression forces dev-image stream opening to fail and verifies the original network-detecting thread policy is restored. The exact baseline leaves the permissive policy installed.
Verification
git diff --checkpassedBreaking changes
None. Failed image decoding continues through the existing error callback; resources and thread policy are now cleaned up reliably.