Add Agilex 5 FCS and wolfBoot integration - #846
Conversation
7e310c9 to
d67e834
Compare
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds an Altera Agilex 5 (013B) port and integration points to boot wolfBoot as BL33 in the GSRD SD-card flow, including SDHCI/platform init, memory mapping, example FIT artifacts, and CI build coverage.
Changes:
- Adds Agilex 5 HAL (C + header), linker script, FIT example, and a BL33 smoke-test app.
- Updates AArch64 startup/MMU mappings and SDHCI behavior to support Agilex 5 boot/SD timing.
- Updates disk-boot logging and adds docs/config + GitHub Actions build coverage for the new target.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test-app/app_agilex5.c | Adds a BL33 smoke-test app for Agilex 5 (timer + EL print). |
| src/update_disk.c | Improves disk-boot debug output (block size + pointer-format prints). |
| src/sdhci.c | Adds command-line reset, inhibit timeouts, optional post-command delay, and CMD8 retry logic. |
| src/boot_aarch64_start.S | Adds Agilex 5 include, adjusts CNTFRQ/RVBAR handling, and adds Agilex 5 MMU mappings. |
| src/boot_aarch64.c | Adds Agilex 5 HAL include selection for AArch64 boot code. |
| include/sdhci.h | Adds reset bit definitions and new SDHCI tuning/behavior macros. |
| hal/agilex5.ld | New linker script matching BL33 placement at 0x80200000. |
| hal/agilex5.its | Example FIT description for Agilex 5 Linux payload (kernel + DTB). |
| hal/agilex5.h | New Agilex 5 target configuration and platform constants. |
| hal/agilex5.c | New Agilex 5 HAL implementation (timer, UART, DT fixups, SDHCI PHY + DMA cache ops). |
| docs/Targets.md | Documents the new Agilex 5 target and references Agilex5 bring-up doc. |
| docs/Agilex5.md | Adds bring-up and integration documentation (GSRD/FIT/WIC/test order/CI). |
| config/examples/agilex5_013b_sdcard.config | Adds a buildable example config for Agilex 5 SD-card boot flow. |
| arch.mk | Adds Agilex 5 AArch64 flags + target-specific bootloader responsibilities. |
| .github/workflows/test-configs.yml | Adds Agilex 5 config to existing CI matrix via reusable workflow. |
| .github/workflows/test-build-agilex5.yml | Adds a dedicated Agilex 5 build workflow (path-filtered). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #846
Scan targets checked: wolfboot-bugs, wolfboot-src
Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
Description
partner pr: wolfSSL/meta-wolfssl#177