wolfHSM: expose max verify roots in options.mk - #847
Open
bigbrett wants to merge 2 commits into
Open
Conversation
bigbrett
requested review from
wolfSSL-Fenrir-bot
and
a lite review from Copilot
August 7, 2026 16:13
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #847
No scan targets match the changed files in this PR. Review skipped.
Contributor
There was a problem hiding this comment.
Pull request overview
Expose WOLFHSM_CFG_CERT_MAX_VERIFY_ROOTS as a user-configurable build option (via .config) and propagate it into wolfHSM client/server builds so the trusted-root maximum used during certificate-chain verification can be kept consistent across builds.
Changes:
- Add
WOLFHSM_CFG_CERT_MAX_VERIFY_ROOTS ?= 8default tooptions.mk. - Pass
-DWOLFHSM_CFG_CERT_MAX_VERIFY_ROOTS=...intoCFLAGSforWOLFHSM_CLIENTandWOLFHSM_SERVERbuilds. - Clarify in the
WOLFHSM_NVM_ROOT_CA_LISTcomment that the max-roots setting is user-configurable and must match the HSM server firmware build.
Suppressed comments (1)
options.mk:1501
- WOLFHSM_CFG_CERT_MAX_VERIFY_ROOTS is now configurable, but it is only propagated into the build via CFLAGS in the WOLFHSM_CLIENT/WOLFHSM_SERVER blocks. The TrustZone wolfHSM server mode (WOLFCRYPT_TZ_WOLFHSM) also builds wolfHSM server code and should define the same value; otherwise overriding this in .config can silently create a client/server wire-format mismatch.
# Maximum trusted-root count for wolfHSM cert-chain verification. Part of the
# client<->server wire format, so every wolfHSM build in the system (wolfBoot
# client or server, and any separately built HSM server firmware) must use
# the same value.
WOLFHSM_CFG_CERT_MAX_VERIFY_ROOTS ?= 8
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes an important wolfHSM config variable to be settable by users via
.config