Skip to content

Add refactored auth tests#398

Open
padelsbach wants to merge 1 commit into
wolfSSL:mainfrom
padelsbach:test-refactor-add-auth
Open

Add refactored auth tests#398
padelsbach wants to merge 1 commit into
wolfSSL:mainfrom
padelsbach:test-refactor-add-auth

Conversation

@padelsbach
Copy link
Copy Markdown
Contributor

@padelsbach padelsbach commented Jun 3, 2026

Notes:

  • When auth is enabled, the posix test now logs in as admin before any tests run so the server allows all messages (see preexisting if (server->auth != NULL) check in
    wh_Server_HandleRequestMessage)
  • Auth tests mostly copied verbatim, except:
    • no separate setup/teardown of server in each test, and instead:
    • at start of each auth test, logout to establish baseline
    • at end of each auth test, log out of any test users, and re-login as admin
  • Fix in legacy code: free testuser4 which was silently leaked

@padelsbach padelsbach marked this pull request as ready for review June 3, 2026 16:56
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #398

No scan targets match the changed files in this PR. Review skipped.

@padelsbach padelsbach force-pushed the test-refactor-add-auth branch from 16baafc to 2c3a125 Compare June 3, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants