Add SealSQ QVault post-quantum TPM Support - #570
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds SealSQ QVault vendor support to wolfTPM and introduces a new “PQC control center” example + CI coverage to exercise TPM 2.0 v1.85 post-quantum algorithms (ML-DSA / Hash-ML-DSA / ML-KEM) on both hardware and the in-tree fwTPM.
Changes:
- Add SealSQ vendor/manufacturer identification plus default SPI wait-state / bus-speed / chip-select settings.
- Add
examples/pqc/pqc_ctrland apqc_ctrl.shtest suite to drive board/control operations and the full ML-DSA/ML-KEM parameter matrix with pre-validation. - Extend build/CI plumbing (autoconf option + GitHub workflows) and documentation to include the new vendor and example tooling.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wolftpm/tpm2.h | Add SealSQ vendor ID constant. |
| wolftpm/tpm2_wrap.h | Add SealSQ manufacturer enum value for wrapper-layer identification. |
| wolftpm/tpm2_types.h | Add SealSQ-specific SPI max Hz defaults and wait-state enablement. |
| src/tpm2_wrap.c | Detect "SEAL" manufacturer string and mark wait-state requirement. |
| hal/tpm_io_linux.c | Default SealSQ SPI chip-select to CE0 on Linux spidev. |
| configure.ac | Add --enable-sealsq autoconf option and selection logic. |
| README.md | Document SealSQ QVault support, build option, and benchmarks. |
| examples/pqc/pqc_ctrl.c | New PQC control tool implementing caps/algs/selftest/random/PCR ops + ML-DSA/ML-KEM matrix with argument validation. |
| examples/pqc/pqc_ctrl.sh | New shell suite to run pqc_ctrl command coverage and argument-validation negatives. |
| examples/pqc/include.am | Build/install distribution wiring for pqc_ctrl and pqc_ctrl.sh. |
| examples/pqc/README.md | Document pqc_ctrl usage and SealSQ QVault run context/benchmarks. |
| examples/run_examples.sh | Run pqc_ctrl board-control commands during v1.85 example runs. |
| .github/workflows/pqc-examples.yml | Run pqc_ctrl.sh in CI for fwTPM-based PQC examples. |
| .github/workflows/pqc-build-matrix.yml | Add a SealSQ vendor-config build job. |
| .gitignore | Ignore new pqc_ctrl and related generated example binaries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #570
Scan targets checked: wolftpm-bugs, wolftpm-src
No new issues found in the changed files. ✅
dgarske
previously approved these changes
Aug 13, 2026
Member
|
aidangarske
force-pushed
the
sealsq-pqc-tpm
branch
from
August 14, 2026 18:44
67b593f to
b57d851
Compare
dgarske
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--enable-sealsqvendor build: "SEAL" manufacturer detection, vendor ID 0x2406, and SPI CE0 chip-select / wait-state defaults.examples/pqc/pqc_ctrlcontrol tool plus apqc_ctrl.shsuite: caps, algorithm list, self-test, get-random, PCR read and extend, transient-object flush, TPM clear, and the full ML-DSA / Hash-ML-DSA / ML-KEM parametermatrix in one CLI.
examples/pqc/pqc_ctrl.shpasses 20/20 on SealSQ QVault TPM hardware and 20/20 over the fwTPM