tidy clang-tidy

[ejohnstown]

Clean up clang-tidy findings across wolfSSH. The checks set initially flagged 378 issues across six categories; this branch clears all of them. Build is clean (exit 0); no functional or wire-protocol changes.

• Add parameter names to function declarations -- name the parameters in public/internal-header function decls and the few forward decls in .c files; clears all 360 readability-named-parameter findings. Prototypes that exceeded 80 columns after the names were added are re-wrapped using the existing 8-space continuation style.
• Remove redundant preprocessor guard -- drop the inner #ifdef WOLFSSH_CERTS inside DoUserAuthRequestRsaCert (the surrounding function is already under the same guard); clears readability-redundant-preprocessor.
• Move unsafe call out of signal handler -- drop fprintf from wolfsshd's interruptCatch and log "Closing down wolfSSHD" from the main accept loop after quit is observed; annotate sftpclient's wolfSSH_SFTP_Interrupt call with NOLINT since it is a single byte store; clears both bugprone-signal-handler findings.
• Use reentrant time conversion in SFTP -- SFTP_CreateLongName switches from XGMTIME (gmtime) to WLOCALTIME, which expands to localtime_r/localtime_s per platform; clears concurrency-mt-unsafe. Server will provide localtimes for ls -l output, except for Zephyr which only provides UTC.
• Tighten SCP timestamp bounds check -- in ParseTimestamp, move ++idx out of the || conditions and tighten the bound from > bufSz to >= bufSz; clears both bugprone-inc-dec-in-conditions findings and fixes a one-past-the-end read.
• Bound sshd Include directive recursion -- track include depth on WOLFSSHD_CONFIG, reject loads past WOLFSSHD_MAX_INCLUDE_DEPTH (16), and annotate the four functions in the include cycle with NOLINTNEXTLINE pointing at the bound; clears all 8 misc-no-recursion findings. Adds a test for the recursion depth.

[Copilot]

Pull request overview

This PR is a clang-tidy cleanup pass across wolfSSH, focused on eliminating diagnostics (primarily readability-named-parameter) while also addressing a few correctness/safety findings (signal-handler safety, SFTP time conversion reentrancy, SCP bounds check, and sshd config include recursion).

Changes:

• Add parameter names to many public/internal header prototypes and a few forward declarations, rewrapping long prototypes to match existing continuation style.
• Improve safety/correctness in a few targeted areas: remove redundant preprocessor guarding, avoid logging from a signal handler, use reentrant time conversion for SFTP longname creation, and tighten an SCP timestamp bounds check.
• Bound Include recursion in wolfsshd configuration loading via a tracked include depth and a maximum depth constant.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
wolfssh/wolfscp.h	Names parameters in SCP API declarations; rewraps long prototypes.
wolfssh/ssh.h	Names parameters in core public API declarations and callback setters.
wolfssh/port.h	Names parameters for select portability-layer prototypes (stdio + string + pread/pwrite).
wolfssh/log.h	Names parameters in the public logging API signature.
wolfssh/internal.h	Names parameters in internal APIs (channels, I/O handlers, packet helpers, SCP helpers).
wolfssh/agent.h	Names parameters in agent API/internal declarations and rewraps long prototypes.
src/wolfsftp.c	Switches SFTP longname time conversion to WLOCALTIME and simplifies preprocessor guards.
src/wolfscp.c	Refactors SCP timestamp parsing to avoid inc/dec inside conditions and tightens bounds.
src/log.c	Updates default logging callback forward-declaration parameter names/wrapping.
src/internal.c	Removes redundant inner #ifdef WOLFSSH_CERTS inside an already-guarded function.
examples/sftpclient/sftpclient.c	Annotates wolfSSH_SFTP_Interrupt() call in signal handler with NOLINT.
examples/scpclient/scpclient.h	Names the thread entry parameter in the example header prototype.
apps/wolfsshd/wolfsshd.c	Removes fprintf from signal handler; logs shutdown message from main loop.
apps/wolfsshd/test/test_configuration.c	Names the fmt parameter in the test logger prototype.
apps/wolfsshd/configuration.c	Adds include-depth tracking + maximum recursion bound; annotates bounded recursion with NOLINTNEXTLINE.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.