Skip to content

PQC enforce modulus and eta range checks in DecodePrivateKey#10603

Draft
aidangarske wants to merge 2 commits into
wolfSSL:masterfrom
aidangarske:pqc-decode-validation
Draft

PQC enforce modulus and eta range checks in DecodePrivateKey#10603
aidangarske wants to merge 2 commits into
wolfSSL:masterfrom
aidangarske:pqc-decode-validation

Conversation

@aidangarske
Copy link
Copy Markdown
Member

@aidangarske aidangarske commented Jun 5, 2026

Description

  • In Add ML-KEM and ML-DSA support wolfProvider#399 I did inter-op test with WP and openssl. There wherre 2 issues with mlkem and mldsa
    1. mlkem specifically needed A modulus check needed to be added to reject non reduced priv key vectors on decode
    1. mldsa needs to reject priv key data with out of range s1/s2
  • Added neg test vectors to fix
  • Tested in WP 2602 interop pass from openssl test suite
  • skoll, copilot, fenrir addressed

@aidangarske aidangarske self-assigned this Jun 5, 2026
Copilot AI review requested due to automatic review settings June 5, 2026 02:01

This comment was marked as resolved.

wolfSSL-Fenrir-bot

This comment was marked as resolved.

@aidangarske aidangarske force-pushed the pqc-decode-validation branch from 12c5cf5 to f558827 Compare June 5, 2026 02:40
@aidangarske aidangarske requested a review from Frauschi June 5, 2026 02:41
@aidangarske aidangarske requested a review from anhu June 5, 2026 02:58
Copy link
Copy Markdown
Contributor

@Frauschi Frauschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @SparkiDev should give the final go on this.

@Frauschi Frauschi assigned SparkiDev and unassigned Frauschi Jun 5, 2026
@Frauschi Frauschi requested a review from SparkiDev June 5, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants