Add separate client cookie enable config - #11101
Open
padelsbach wants to merge 3 commits into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11101
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
padelsbach
force-pushed
the
client-cookie-enable
branch
from
August 6, 2026 22:43
fec3b81 to
9a5aabf
Compare
|
Member
|
Jenkins retest this please |
dgarske
requested changes
Aug 7, 2026
dgarske
requested changes
Aug 7, 2026
dgarske
left a comment
Member
There was a problem hiding this comment.
Testing configuration:
--enable-tls13 --disable-tlsv12 --enable-secure-renegotiation --enable-nullcipher CFLAGS="-DNO_WOLFSSL_CLIENT"
1579: test_tls13_server_cookie_parse :
ERROR - tests/api/test_tls13.c line 7835 failed with:
expected: TLSX_Parse(ssl, badExt, (word16)sizeof(badExt), client_hello, (Suites*)((const Suites*) ((ssl)->suites != ((void *)0) ? (ssl)->suites : (ssl)->ctx->suites))) == (BUFFER_E)
result: 0 != -132
failed ( 0.00005)
ERROR - tests/api.c line 39831 failed with:
expected: Test failed
result: ret 0
Contributor
Author
|
jenkins retest this please |
padelsbach
force-pushed
the
client-cookie-enable
branch
from
August 7, 2026 20:32
af7f938 to
5cd590b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split the existing flag which enables TLS cookie support
WOLFSSL_SEND_HRR_COOKIEinto a smaller portionWOLFSSL_TLS13_COOKIEwhich enables replying with a cookie echo'ed from the HelloClientResponse (HRR). This is enabled by default for clients.Fixes #11074
Testing
New unit test
Checklist