Repository navigation
Conversation
…missing exemptions to the FIPS v7 refusals: for $ENABLED_MLDSA_NO_CTX / WOLFSSL_MLDSA_NO_CTX / WOLFSSL_MLDSA_FIPS204_DRAFT, when fips-dev and experimental are both enabled; and for $ENABLED_AESSIV / WOLFSSL_AES_SIV, $ENABLED_AESEAX / WOLFSSL_AES_EAX, $ENABLED_AESGCMSIV / WOLFSSL_AESGCM_SIV, $ENABLED_AESCTS / WOLFSSL_AES_CTS, and $ENABLED_AESKEYWRAP_PADDING / WOLFSSL_AES_KEYWRAP_PADDING, when fips-dev is enabled.
There was a problem hiding this comment.
🔵 Needs a closer look
Integration of the FIPS-boundary exemptions with wolfssl/fips#437 needs validation because the companion changes and FIPS overlay are unavailable in this checkout.
No open issues 🎉
What changed in this PR
This PR adds development-only exemptions to wolfSSL’s FIPS v7 feature restrictions while preserving the restrictions for non-development FIPS builds.
Changes:
- Permit ML-DSA no-context and draft APIs when both FIPS development mode and experimental settings are enabled.
- Permit AES-SIV, EAX, GCM-SIV, CTS, and key-wrap padding in FIPS development mode.
- Align configure-time checks with source-level guards.
| File | Description |
|---|---|
wolfssl/wolfcrypt/wc_mldsa.h |
Exempts experimental FIPS development builds from ML-DSA API restrictions. |
wolfcrypt/src/aes.c |
Exempts FIPS development builds from the listed AES feature restrictions. |
configure.ac |
Adds corresponding development-mode exemptions to configuration checks. |
Review effort: Balanced
|
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #12114
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): configure.ac
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Max
configure.ac,wolfcrypt/src/aes.c,wolfssl/wolfcrypt/wc_mldsa.h: add missing exemptions to the FIPS v7 refusals: for$ENABLED_MLDSA_NO_CTX/WOLFSSL_MLDSA_NO_CTX/WOLFSSL_MLDSA_FIPS204_DRAFT, when fips-dev and experimental are both enabled; and for$ENABLED_AESSIV/WOLFSSL_AES_SIV,$ENABLED_AESEAX/WOLFSSL_AES_EAX,$ENABLED_AESGCMSIV/WOLFSSL_AESGCM_SIV,$ENABLED_AESCTS/WOLFSSL_AES_CTS, and$ENABLED_AESKEYWRAP_PADDING/WOLFSSL_AES_KEYWRAP_PADDING, when fips-dev is enabled.tested with
With wolfssl/fips#437