Skip to content

20261112-fips-dev-exemptions - #12114

Open
douzzer wants to merge 1 commit into
wolfSSL:masterfrom
douzzer:20261112-fips-dev-exemptions
Open

douzzer wants to merge 1 commit into
wolfSSL:masterfrom
douzzer:20261112-fips-dev-exemptions

Conversation

@douzzer

@douzzer douzzer commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

configure.ac, wolfcrypt/src/aes.c, wolfssl/wolfcrypt/wc_mldsa.h: add missing exemptions to the FIPS v7 refusals: for $ENABLED_MLDSA_NO_CTX / WOLFSSL_MLDSA_NO_CTX / WOLFSSL_MLDSA_FIPS204_DRAFT, when fips-dev and experimental are both enabled; and for $ENABLED_AESSIV / WOLFSSL_AES_SIV, $ENABLED_AESEAX / WOLFSSL_AES_EAX, $ENABLED_AESGCMSIV / WOLFSSL_AESGCM_SIV, $ENABLED_AESCTS / WOLFSSL_AES_CTS, and $ENABLED_AESKEYWRAP_PADDING / WOLFSSL_AES_KEYWRAP_PADDING, when fips-dev is enabled.

tested with

wolfssl-multi-test.sh ...
fips-140-3-dev-optest-acvp-sp-asm
fips-140-3-ready-optest-acvp-sp-asm
check-configure
check-source-text

With wolfssl/fips#437

…missing

exemptions to the FIPS v7 refusals: for $ENABLED_MLDSA_NO_CTX /
WOLFSSL_MLDSA_NO_CTX / WOLFSSL_MLDSA_FIPS204_DRAFT, when fips-dev and
experimental are both enabled; and for $ENABLED_AESSIV / WOLFSSL_AES_SIV,
$ENABLED_AESEAX / WOLFSSL_AES_EAX, $ENABLED_AESGCMSIV / WOLFSSL_AESGCM_SIV,
$ENABLED_AESCTS / WOLFSSL_AES_CTS, and $ENABLED_AESKEYWRAP_PADDING /
WOLFSSL_AES_KEYWRAP_PADDING, when fips-dev is enabled.
@douzzer douzzer added the For FIPS v7 Module Related to FIPS v7.0.0 module prep for submission label Nov 12, 2026
Copilot AI balanced review requested due to automatic review settings November 12, 2026 17:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Integration of the FIPS-boundary exemptions with wolfssl/fips#437 needs validation because the companion changes and FIPS overlay are unavailable in this checkout.

No open issues 🎉

What changed in this PR

This PR adds development-only exemptions to wolfSSL’s FIPS v7 feature restrictions while preserving the restrictions for non-development FIPS builds.

Changes:

  • Permit ML-DSA no-context and draft APIs when both FIPS development mode and experimental settings are enabled.
  • Permit AES-SIV, EAX, GCM-SIV, CTS, and key-wrap padding in FIPS development mode.
  • Align configure-time checks with source-level guards.
File Description
wolfssl/​wolfcrypt/​wc_mldsa.h Exempts experimental FIPS development builds from ML-DSA API restrictions.
wolfcrypt/​src/​aes.c Exempts FIPS development builds from the listed AES feature restrictions.
configure.ac Adds corresponding development-mode exemptions to configuration checks.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

MemBrowse Memory Report · Explore what changed →

zephyr-frdm_rw612

  • FLASH: datas +16 B, log_const_area -8 B, rodata +36 B, text +11,680 B (+4.2%, 294,188 B / 67,108,864 B, total: 0% used)
  • RAM: bss +49 B, datas +16 B (+0.1%, 58,423 B / 983,040 B, total: 6% used)

No memory changes detected for:


Catch memory regressions in CI with MemBrowse. Free for open source.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #12114

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): configure.ac
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For FIPS v7 Module Related to FIPS v7.0.0 module prep for submission

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants